[petsc-dev] reminder never use #include "mylocalinclude.h" in PETSc source

Jed Brown jed at 59A2.org
Tue May 4 15:45:27 CDT 2010


On Tue, 4 May 2010 13:32:46 -0700, Barry Smith <bsmith at mcs.anl.gov> wrote:
> > If you were to move it into the source file, it could be as simple as
> >
> >  #if PETSC_HAVE_XXX
> >  /* body of file */
> >  #endif
> 
>    we bagged this because some compilers couldn't handle source files  
> with no source :-(

So you're suggesting just writing it into comments?  At that point, it
seems better to keep it where it currently is, but the distinction is
becoming a bike shed.

>    plus it is ugly.

Indeed.

Jed



More information about the petsc-dev mailing list