[petsc-dev] Stop breaking my build

Shri abhyshr at mcs.anl.gov
Thu Aug 19 18:12:18 CDT 2010



I'm not sure whether DVI should have support for complex type since complex variables with real upper and lower bounds don't make sense to me and i don't know of any actual problems which have or need complex bounds.


----- Barry Smith <bsmith at mcs.anl.gov> wrote:
> 
>   Shri,
> 
>     Since this is development code that only you are working on you can "protect" its use by putting a 
> #requirespackage  'PETSC_USE_DVI' 
> in the makefile in that directory and if you register the method in SNESRegisterAll() then protect it with 
> #if defined(PETSC_USE_DVI) 
> then define PETSC_USE_DVI in $PETSC_ARCH/include/petscconf.h
> this way you can "be sloppy" but other people will still have access to your new stuff if they want it in the repository. Then later when the code is ready for general builds take out the ifdefs

Ok. I've done this.
> 
> 
>    Barry
> 
> 
> On Aug 19, 2010, at 2:02 PM, Shri wrote:
> 
> > 
> > 
> >> Shri - looks like merit should be PetscReal - not PetscComplex [pusing
> >> a fix for this. If this is incorrect - you can revert my change]
> >> 
> >  That's correct...thanks.I am building petsc with complex right now to see if there are any other changes needed.
> > 
> >> Satish
> > 
> 




More information about the petsc-dev mailing list