who broke PCFieldSplit code in petsc-dev?????????

[Barry Smith]

    Matt.

      That is not the fix; that is irrelevent.

     A couple of weeks ago these examples ran fine and did not crash.  
Now they crash. Perhaps it was not a change to fieldsplit that caused  
the recent crashes, but it is a recent change to something.

      The examples ran fine after the change to MatGetSubMatrix() I am  
pretty sure.

    If we were smart we would keep the results of each nights nightly  
builds and then we could easily check what DAY things broke. Satish  
please have it save the old days stuff for each day.


    Barry

On Nov 11, 2009, at 5:56 PM, Matthew Knepley wrote:

> Fixed.
>
>   Matt
>
> On Wed, Nov 11, 2009 at 5:46 PM, Lisandro Dalcin <dalcinl at gmail.com>  
> wrote:
> On Wed, Nov 11, 2009 at 8:41 PM, Matthew Knepley <knepley at gmail.com>  
> wrote:
> > I have 5 args for fieldsplit.c:290.
> >
>
> But the traceback Barry posted says arg #6 is wrong... In short,
> MatGetSubMatrix() needs a little fix in a couple of
> PetscValidHeaderSpecific ...
>
> >   Matt
> >
> > On Wed, Nov 11, 2009 at 5:27 PM, Lisandro Dalcin  
> <dalcinl at gmail.com> wrote:
> >>
> >> On Wed, Nov 11, 2009 at 8:23 PM, Matthew Knepley  
> <knepley at gmail.com>
> >> wrote:
> >> > Has this been broken for a while? It bombs in  
> MatGetSubMatrix(), and
> >> > this
> >> > had an API change. The
> >> > last change in fieldsplit.c is in July, by Jed.
> >> >
> >>
> >> BTW, the #arg is wrong, it should be #5...
> >>
> >> >   Matt
> >> >
> >> > On Wed, Nov 11, 2009 at 5:16 PM, Barry Smith  
> <bsmith at mcs.anl.gov> wrote:
> >> >>
> >> >> See for example
> >> >>
> >> >>  http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/examples_arch-linux-gcc-pgf90_grind.log 
>  search
> >> >> for PCSetUp_FieldSplit().
> >> >>
> >> >> Please fix ASAP.
> >> >>
> >> >>   Thanks.
> >> >>
> >> >>   Barry
> >> >>
> >> >> And remember before pushing you should run "make alltests" to  
> make sure
> >> >> you haven't introduced problems.
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > What most experimenters take for granted before they begin their
> >> > experiments
> >> > is infinitely more interesting than any results to which their
> >> > experiments
> >> > lead.
> >> > -- Norbert Wiener
> >> >
> >>
> >>
> >>
> >> --
> >> Lisandro Dalcín
> >> ---------------
> >> Centro Internacional de Métodos Computacionales en Ingeniería  
> (CIMEC)
> >> Instituto de Desarrollo Tecnológico para la Industria Química  
> (INTEC)
> >> Consejo Nacional de Investigaciones Científicas y Técnicas  
> (CONICET)
> >> PTLC - Güemes 3450, (3000) Santa Fe, Argentina
> >> Tel/Fax: +54-(0)342-451.1594
> >
> >
> >
> > --
> > What most experimenters take for granted before they begin their  
> experiments
> > is infinitely more interesting than any results to which their  
> experiments
> > lead.
> > -- Norbert Wiener
> >
>
>
>
> --
> Lisandro Dalcín
> ---------------
> Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
> Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
> Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
> PTLC - Güemes 3450, (3000) Santa Fe, Argentina
> Tel/Fax: +54-(0)342-451.1594
>
>
>
> -- 
> What most experimenters take for granted before they begin their  
> experiments is infinitely more interesting than any results to which  
> their experiments lead.
> -- Norbert Wiener