changes to MatSetOption() in petsc-dev

Barry Smith bsmith at mcs.anl.gov
Mon Jul 9 16:22:26 CDT 2007



On Mon, 9 Jul 2007, Lisandro Dalcin wrote:

> On 7/9/07, Barry Smith <bsmith at mcs.anl.gov> wrote:
> >     I have pushed a change to the MatSetOption() function.
> 
> Barry, a couple of comments
> 
> * I think MAT_NO_NEW_NONZERO_LOCATIONS should be
> MAT_NEW_NONZERO_LOCATIONS, for symmetry with the other option names.

  Fine,

> 
> * I think all the MAT_INODE_LIMIT_[1..5] could be perhaps removed from
> MatOption, and add a new function MatSetInodeLimit(Mat A, PetscInt
> limit). 

   Sounds ok.

> Not sure what to do with  MAT_USE_INODE. Perhpas it can be

   Can just leave it as an on-off switch as it is now

> also removed, and use the previous function (with limit==0, no inodes,
> and with 1 <= limit <=5, use inodes with that limit)
> 
> * You removed the MAT_[ROW|COLUMN]_SORTED stuff. I think you should
> keep it, even when this feature is not yet implemented.

  It is not a mater of being implemented, it used to be used but is not
needed IMHO. What do you think it would be used for?

   Thanks,

   Barry
> 
> 
> 




More information about the petsc-dev mailing list