Writing large files from pnetcdf on IBM

[Robert Latham]

On Tue, Nov 28, 2006 at 01:33:06PM -0600, Robert Latham wrote:
> Ok, this is good information, especially that the NF_64BIT_OFFSET flag
> is not creating CDF-2 files.  I will have to dig into this.  I'll send
> an update when I know more...

As it turns out, John and I have both found the problem.  I introduced
this bug while merging in some changes with serial netcdf, and it has
remained undetected for some time.  There do not appear to be other bugs of
this type from that merge. 

The attached patch will fix the problem of not creating CDF-2
formatted files.  John, please give it a shot and let me know how the
creation of your +2GB data sets works out.

Again, thanks for John's bug report and speedy followups.

==rob

-- 
Rob Latham
Mathematics and Computer Science Division    A215 0178 EA2D B059 8CDF
Argonne National Lab, IL USA                 B29D F333 664A 4280 315B
-------------- next part --------------
---------------------
PatchSet 482 
Date: 2006/11/28 21:54:39
Author: robl
Branch: HEAD
Tag: (none) 
Log:
John Michalakes reported a bug that parallel-netcdf was not creating CDF-2
formated files.  We were not updating the correct variable with the
NC_64BIT_OFFSET flag

Members: 
	src/lib/mpinetcdf.c:1.48->1.49 

Index: parallel-netcdf/src/lib/mpinetcdf.c
diff -u parallel-netcdf/src/lib/mpinetcdf.c:1.48 parallel-netcdf/src/lib/mpinetcdf.c:1.49
--- parallel-netcdf/src/lib/mpinetcdf.c:1.48	Mon Apr 17 11:20:33 2006
+++ parallel-netcdf/src/lib/mpinetcdf.c	Tue Nov 28 15:54:39 2006
@@ -83,7 +83,7 @@
 	   * that's a hassle we don't want to worry about */
 	  if (sizeof(off_t) != 8)
 		  return NC_ESMALL;
-	  fSet(cmode, NC_64BIT_OFFSET);
+	  fSet(ncp->flags, NC_64BIT_OFFSET);
 	  sizeof_off_t = 8;
   } else {
 	  sizeof_off_t = 4;