[mpich2-commits] r5501 - in mpich2/trunk/src: include util/mem

goodell at mcs.anl.gov goodell at mcs.anl.gov
Tue Oct 20 15:35:34 CDT 2009


Author: goodell
Date: 2009-10-20 15:35:34 -0500 (Tue, 20 Oct 2009)
New Revision: 5501

Modified:
   mpich2/trunk/src/include/mpihandlemem.h
   mpich2/trunk/src/util/mem/handlemem.c
Log:
Improve handle reference counting log messages.

No reviewer.

Modified: mpich2/trunk/src/include/mpihandlemem.h
===================================================================
--- mpich2/trunk/src/include/mpihandlemem.h	2009-10-20 20:35:32 UTC (rev 5500)
+++ mpich2/trunk/src/include/mpihandlemem.h	2009-10-20 20:35:34 UTC (rev 5501)
@@ -292,6 +292,14 @@
         if (handle_kind_ != HANDLE_KIND_BUILTIN) {             \
             MPIU_Object_add_ref_always((objptr_));             \
         }                                                      \
+        else {                                                                                                 \
+            MPIU_DBG_MSG_FMT(HANDLE,TYPICAL,(MPIU_DBG_FDEST,                                                   \
+                                             "skipping add_ref on %p (0x%08x kind=%s) refcount=%d",            \
+                                             (objptr_),                                                        \
+                                             (objptr_)->handle,                                                \
+                                             MPIU_Handle_get_kind_str(HANDLE_GET_MPI_KIND((objptr_)->handle)), \
+                                             MPIU_Object_get_ref(objptr_)))                                    \
+        }                                                                                                      \
     } while (0)
 #define MPIU_Object_release_ref(objptr_,inuse_ptr_)                  \
     do {                                                             \
@@ -301,6 +309,12 @@
         }                                                            \
         else {                                                       \
             *(inuse_ptr_) = 1;                                       \
+            MPIU_DBG_MSG_FMT(HANDLE,TYPICAL,(MPIU_DBG_FDEST,                                                   \
+                                             "skipping release_ref on %p (0x%08x kind=%s) refcount=%d",        \
+                                             (objptr_),                                                        \
+                                             (objptr_)->handle,                                                \
+                                             MPIU_Handle_get_kind_str(HANDLE_GET_MPI_KIND((objptr_)->handle)), \
+                                             MPIU_Object_get_ref(objptr_)))                                    \
         }                                                            \
     } while (0)
 

Modified: mpich2/trunk/src/util/mem/handlemem.c
===================================================================
--- mpich2/trunk/src/util/mem/handlemem.c	2009-10-20 20:35:32 UTC (rev 5500)
+++ mpich2/trunk/src/util/mem/handlemem.c	2009-10-20 20:35:34 UTC (rev 5501)
@@ -387,8 +387,11 @@
     MPIU_VG_MAKE_MEM_UNDEFINED(&obj->next, sizeof(obj->next));
 
     MPIU_DBG_MSG_FMT(HANDLE,TYPICAL,(MPIU_DBG_FDEST,
-                                     "Freeing object ptr %p (handle val 0x%08x)",
-                                     obj, obj->handle));
+                                     "Freeing object ptr %p (0x%08x kind=%s) refcount=%d",
+                                     (obj),
+                                     (obj)->handle,
+                                     MPIU_Handle_get_kind_str(HANDLE_GET_MPI_KIND((obj)->handle)),
+                                     MPIU_Object_get_ref(obj)));
 
     obj->next	        = objmem->avail;
     objmem->avail	= obj;



More information about the mpich2-commits mailing list