[ROMIO Req #904] [mpich-discuss] ad_pvfs2/ad_pvfs2_aio.c PVFS_isys_read

[Robert Latham]

On Fri, Mar 07, 2008 at 10:36:46AM -0600, Wei-keng Liao wrote:
> 
> I got a compile warning (from buliding mpich2-1.0.6p1):
>   ad_pvfs2_aio.c:95: warning: passing argument 9 of 'PVFS_isys_io' makes 
>   pointer from integer without a cast
>   ad_pvfs2_aio.c:105: warning: passing argument 9 of 'PVFS_isys_io' makes 
>   pointer from integer without a cast
> 
> In file ad_pvfs2/ad_pvfs2_aio.c, lines 97 and 107, shouldn't
>   aio_req->op_id
> be
>   &(aio_req->op_id)
> ?

You're absolutely right, Wei-keng.  I fixed that in SVN at some point, but
apparently after the 1.0.6 branch was made.  The good news is
that I don't think 1.0.6 actually makes use of pvfs2 AIO routines.

> Also there are other warnings that I don't know how to fix:
>   ad_pvfs2_read.c: In function 'ADIOI_PVFS2_ReadStrided':
>   ad_pvfs2_read.c:486: warning: cast from pointer to integer of different 
>   size
> 
>   ad_pvfs2_write.c: In function 'ADIOI_PVFS2_WriteStrided':
>   ad_pvfs2_write.c:540: warning: cast from pointer to integer of different 
>   size
> 
> I am compiling it on a 64-bit machine.

we've had those warnings forever.  They do make me uneasy but I
haven't made the time to figure out the correct casting to
make that go away.

==rob

-- 
Rob Latham
Mathematics and Computer Science Division    A215 0178 EA2D B059 8CDF
Argonne National Lab, IL USA                 B29D F333 664A 4280 315B