[MOAB-dev] Moab and C++17

[John R Cary]

No, Paul, our port does not presume Bilder is being used.  But there were
numerous conflicts that will take time and effort to work through.

My only concern is that if we get our Windows stuff merged into our fork
of current master, and after that our PR is accepted after PR405, then 
it will
be like starting over.

So is PR405 on hold for now?  Or might it be merged in the next few months?

Thanks.....John

On 10/22/19 12:22 PM, Paul Wilson wrote:
>
> Hi John,
>
> A few comments:
>
>   * The existing PR's have languished for some time because most of us
>     with MOAB expertise have very little Windows experience.  I'm not
>     sure it's worth waiting for them to be merged first if you already
>     have a Windows port working.
>   * One of the goals of PR405 was to minimize dependencies for a
>     minimally acceptable build.  To that end, it avoids relying on
>     LAPACK/BLAS because that comes with FORTRAN expectations, which
>     comes with FORTRAN compiler needs, all of which explode the
>     dependencies.  We also wanted to minimize how intrusive we were. 
>     We were able to build it with only:
>       o VisualStudio C++
>       o CMake
>       o HDF5
>       o Eigen3
>   * Does your port presume that Bilder is being used?
>
> Thanks,
>
> Paul
>
> On 10/22/19 10:55, John R Cary via moab-dev wrote:
>> Thanks, Paul.  We do have Moab ported to Windows and working, so we could
>> set a PR, but first we have to sync-up, and there are lots of conflicts.
>>
>> So before we start on this, we would prefer that all other work on 
>> Windows
>> ports be in so that we do not duplicate effort.  Would this be possible
>> in a modest amount of time?
>>
>> In response to Vijay -- we build our toolchain on multiple platforms
>> (Windows VS, Windows LLVM, macOS same, Linux various compilers) using
>> Jenkins as the driver and our own Bilder as a package manager for 
>> building
>> and running tests.
>>
>> To make sure I understand, we should branch off master -- after you get
>> current PRs in.  Then add our code.  Then submit a pull request to your
>> develop.  Is this right?
>>
>> Thx.....John
>>
>> On 10/22/19 11:27 AM, Paul Wilson wrote:
>>>
>>> Hi John,
>>>
>>> There have been a few attempts at a Windows port - or partial 
>>> windows ports - that live in branches and/or PRs. I'm most familiar 
>>> with this one: 
>>> https://bitbucket.org/fathomteam/moab/pull-requests/405 
>>> <https://bitbucket.org/fathomteam/moab/pull-requests/405> that 
>>> Baptiste worked on.
>>>
>>> Paul
>>>
>>> On 10/22/19 10:11, John R Cary via moab-dev wrote:
>>>> Thanks, Vijay.
>>>>
>>>> On a related note, we had started porting Moab to Windows.  When 
>>>> merging
>>>> our changes to your develop branch, we found a number of conflicts.
>>>>
>>>> Did you port Moab to Windows?
>>>>
>>>> And you still want pull requests to your develop branch?
>>>>
>>>> Thx.....John
>>>>
>>>> On 10/22/19 10:24 AM, Vijay S. Mahadevan wrote:
>>>>> John,
>>>>>
>>>>> AFAIK, no one has verified this. If you already have some checks, 
>>>>> please let us know and we will try to fix incompatibility. Or if 
>>>>> you can submit changes as PRs, thst would be much appreciated.
>>>>>
>>>>> I do want to note that MOAB is C++03 compliant still and we only 
>>>>> recently started adding new dependencies that have C++11 
>>>>> requirements.
>>>>>
>>>>> Thanks,
>>>>> Vijay
>>>>>
>>>>>
>>>>> On Tue., Oct. 22, 2019, 8:58 a.m. John R Cary via moab-dev, 
>>>>> <moab-dev at mcs.anl.gov <mailto:moab-dev at mcs.anl.gov>> wrote:
>>>>>
>>>>>     We have recently ported most of our build chain to c++17.
>>>>>     However, our fork of moab is not c++-17 compliant. Is the
>>>>>     main repo c++17 compliant?
>>>>>
>>>>>     Thx....John Cary
>>>>>
>>>>
>>> -- 
>>> -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ --
>>> Paul P.H. Wilson (he/him/his)
>>> Grainger Professor of Nuclear Engineering
>>> Chair, Department of Engineering Physics <http://engr.wisc.edu/ep>
>>> Chair, Energy Analysis and Policy Certificate <http://eap.wisc.edu>
>>> 608-263-0807
>>> paul.wilson at wisc.edu
>>> 153 Engineering Research Bldg
>>> 1500 Engineering Dr, Madison, WI 53706
>>>
>>> Computational Nuclear Engineering Research Group 
>>> <http://cnerg.engr.wisc.edu>
>>>
>>
> -- 
> -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ --
> Paul P.H. Wilson (he/him/his)
> Grainger Professor of Nuclear Engineering
> Chair, Department of Engineering Physics <http://engr.wisc.edu/ep>
> Chair, Energy Analysis and Policy Certificate <http://eap.wisc.edu>
> 608-263-0807
> paul.wilson at wisc.edu
> 153 Engineering Research Bldg
> 1500 Engineering Dr, Madison, WI 53706
>
> Computational Nuclear Engineering Research Group 
> <http://cnerg.engr.wisc.edu>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/moab-dev/attachments/20191022/c0188e2b/attachment.html>