[MOAB-dev] r5899 - in MOAB/trunk: . itaps/igeom itaps/imesh src src/io src/io/mhdf/example src/io/mhdf/src src/moab src/parallel src/parallel/moab tools tools/dagmc

[tautges at mcs.anl.gov]

Author: tautges
Date: 2012-12-05 18:13:22 -0600 (Wed, 05 Dec 2012)
New Revision: 5899

Modified:
   MOAB/trunk/configure.ac
   MOAB/trunk/itaps/igeom/FBiGeom_MOAB.cpp
   MOAB/trunk/itaps/igeom/FBiGeom_MOAB.hpp
   MOAB/trunk/itaps/imesh/MBIter.hpp
   MOAB/trunk/itaps/imesh/iMesh_MOAB.cpp
   MOAB/trunk/src/AdaptiveKDTree.cpp
   MOAB/trunk/src/AffineXform.hpp
   MOAB/trunk/src/BSPTree.cpp
   MOAB/trunk/src/BSPTreePoly.cpp
   MOAB/trunk/src/Core.cpp
   MOAB/trunk/src/DualTool.cpp
   MOAB/trunk/src/ElementSequence.hpp
   MOAB/trunk/src/EntitySequence.hpp
   MOAB/trunk/src/FBEngine.cpp
   MOAB/trunk/src/GeomTopoTool.cpp
   MOAB/trunk/src/MergeMesh.cpp
   MOAB/trunk/src/MeshSet.cpp
   MOAB/trunk/src/MeshSet.hpp
   MOAB/trunk/src/MeshSetSequence.cpp
   MOAB/trunk/src/MeshTopoUtil.cpp
   MOAB/trunk/src/OrientedBox.cpp
   MOAB/trunk/src/OrientedBox.hpp
   MOAB/trunk/src/OrientedBoxTreeTool.cpp
   MOAB/trunk/src/PolyElementSeq.hpp
   MOAB/trunk/src/ProgOptions.cpp
   MOAB/trunk/src/Range.cpp
   MOAB/trunk/src/ReaderWriterSet.cpp
   MOAB/trunk/src/ReorderTool.cpp
   MOAB/trunk/src/ScdElementData.cpp
   MOAB/trunk/src/ScdElementData.hpp
   MOAB/trunk/src/ScdInterface.cpp
   MOAB/trunk/src/SequenceData.cpp
   MOAB/trunk/src/SequenceData.hpp
   MOAB/trunk/src/SetIterator.cpp
   MOAB/trunk/src/SmoothCurve.cpp
   MOAB/trunk/src/SmoothFace.cpp
   MOAB/trunk/src/SpectralMeshTool.cpp
   MOAB/trunk/src/StructuredElementSeq.cpp
   MOAB/trunk/src/SweptElementData.cpp
   MOAB/trunk/src/SweptElementSeq.cpp
   MOAB/trunk/src/UnstructuredElemSeq.cpp
   MOAB/trunk/src/VarLenTag.hpp
   MOAB/trunk/src/VertexSequence.hpp
   MOAB/trunk/src/io/ReadGCRM.cpp
   MOAB/trunk/src/io/ReadHDF5.cpp
   MOAB/trunk/src/io/ReadNC.cpp
   MOAB/trunk/src/io/ReadNC.hpp
   MOAB/trunk/src/io/ReadNCDF.cpp
   MOAB/trunk/src/io/ReadSmf.cpp
   MOAB/trunk/src/io/ReadTemplate.cpp
   MOAB/trunk/src/io/ReadTxt.cpp
   MOAB/trunk/src/io/ReadVtk.cpp
   MOAB/trunk/src/io/SMF_State.cpp
   MOAB/trunk/src/io/Tqdcfr.cpp
   MOAB/trunk/src/io/WriteCCMIO.cpp
   MOAB/trunk/src/io/WriteGmsh.cpp
   MOAB/trunk/src/io/WriteHDF5.cpp
   MOAB/trunk/src/io/WriteSLAC.cpp
   MOAB/trunk/src/io/mhdf/example/info.c
   MOAB/trunk/src/io/mhdf/src/file-desc.c
   MOAB/trunk/src/io/mhdf/src/file.c
   MOAB/trunk/src/io/mhdf/src/tags.c
   MOAB/trunk/src/io/mhdf/src/util.c
   MOAB/trunk/src/moab/BSPTree.hpp
   MOAB/trunk/src/moab/HomXform.hpp
   MOAB/trunk/src/moab/Matrix3.hpp
   MOAB/trunk/src/moab/Range.hpp
   MOAB/trunk/src/moab/ScdInterface.hpp
   MOAB/trunk/src/moab/SetIterator.hpp
   MOAB/trunk/src/moab_mpe.h
   MOAB/trunk/src/parallel/ParallelComm.cpp
   MOAB/trunk/src/parallel/ReadParallel.cpp
   MOAB/trunk/src/parallel/moab/gs.hpp
   MOAB/trunk/tools/dagmc/DagMC.cpp
   MOAB/trunk/tools/dagmc/obb_analysis.cpp
   MOAB/trunk/tools/measure.cpp
   MOAB/trunk/tools/size.cpp
Log:
Turning on painfully-verbose warnings in gnu compiler.  Thanks to 
Robert Maynard at Kitware for pointing out these options.  Also removed
most of the warnings I could find, though a few I wasn't sure about
so left them in for now.

Going forward, if you see warnings in your code, please remove them
before committing.  If you're not sure how, please ask by email.

Passes make check, serial and parallel.



Modified: MOAB/trunk/configure.ac
===================================================================
--- MOAB/trunk/configure.ac	2012-12-05 17:56:44 UTC (rev 5898)
+++ MOAB/trunk/configure.ac	2012-12-06 00:13:22 UTC (rev 5899)
@@ -21,7 +21,7 @@
   [No Fortran name mangling in ITAPS/MBCN C headers])],
   [ENABLE_FORTRAN=$enableval],[ENABLE_FORTRAN=yes])
 
-EXTRA_GNU_FLAGS='-Wall -pipe -pedantic -Wno-long-long'
+EXTRA_GNU_FLAGS='-Wall -pipe -pedantic -Wno-long-long -Wextra -Wcast-align  -Wpointer-arith -Wformat -Wformat-security -Wshadow -Wunused-parameter'
 EXTRA_INTEL_FLAGS='-Wall'
 FATHOM_CHECK_COMPILERS([yes],[yes],[$ENABLE_FORTRAN])
 AM_CONDITIONAL(PARALLEL,[test "x$WITH_MPI" != "xno"])

Modified: MOAB/trunk/itaps/igeom/FBiGeom_MOAB.cpp
===================================================================
--- MOAB/trunk/itaps/igeom/FBiGeom_MOAB.cpp	2012-12-05 17:56:44 UTC (rev 5898)
+++ MOAB/trunk/itaps/igeom/FBiGeom_MOAB.cpp	2012-12-06 00:13:22 UTC (rev 5899)
@@ -14,9 +14,9 @@
 using namespace moab;
 
 static int compare_no_case1(const char *str1, const char *str2, size_t n) {
-   for (size_t i = 1; i != n && *str1 && toupper(*str1) == toupper(*str2);
-        ++i, ++str1, ++str2);
-   return toupper(*str2) - toupper(*str1);
+  for (size_t i = 1; i != n && *str1 && toupper(*str1) == toupper(*str2);
+       ++i, ++str1, ++str2);
+  return toupper(*str2) - toupper(*str1);
 }
 // Filter out non-MOAB options and remove the "moab:" prefix
 static std::string filter_options1(const char *begin, const char *end)
@@ -45,15 +45,15 @@
 bool debug_igeom = false;
 bool Debug_surf_eval = false;
 
-#define COPY_RANGE(r, vec) {                      \
-    EntityHandle *tmp_ptr = reinterpret_cast<EntityHandle*>(vec);	\
-    std::copy(r.begin(), r.end(), tmp_ptr);}
+#define COPY_RANGE(r, vec) {                                          \
+      EntityHandle *tmp_ptr = reinterpret_cast<EntityHandle*>(vec);	\
+      std::copy(r.begin(), r.end(), tmp_ptr);}
 
 #define TAG_HANDLE(tagh) reinterpret_cast<Tag>(tagh)
 
-#define COPY_DOUBLEVEC(r, vec) {                      \
-  double *tmp_ptr = reinterpret_cast<double*>(vec); \
-  std::copy(r.begin(), r.end(), tmp_ptr);}
+#define COPY_DOUBLEVEC(r, vec) {                            \
+      double *tmp_ptr = reinterpret_cast<double*>(vec);     \
+      std::copy(r.begin(), r.end(), tmp_ptr);}