itaps-parallel [Fwd: iBase and iMesh changes]
Jason Kraftcheck
kraftche at cae.wisc.edu
Thu Mar 12 14:38:16 CDT 2009
I have *not* yet incorporated any of the further changes that were brought
up during the last telecon. As best I recall, those included:
o Remove 'in_entity_set' output array from iMesh_getAdjEntities
o Remove redundant/unnecessary size arguments from:
iMesh_getAdjTable : adjacency_table_size
iMesh_getVtxArrCoords* : coords_size
iMesh_getAdjEntities : offset_size
iMesh_getEntArrTopo : topology_size
iMesh_getEntArrType : type_size
iMesh_getEntArrAdj : offset_size
iMesh_getEntArr2ndAdj : offset_size
iMesh_getAdjEntIndices : offset_size
iMesh_isEntArrContained: is_contained_size
iMesh_setVtxArrCoords* : new_coords_size
iMesh_createVtxArr : new_vertex_handles_size
iMesh_createEntArr* : new_entity_handles_size
iMesh_getArrData** : tag_values_size
iMesh_getIntArrData** : tag_values_size
iMesh_getDblArrData** : tag_values_size
iMesh_getEHArrData** : tag_values_size
iMesh_setArrData** : tag_values_size
iMesh_setIntArrData** : tag_values_size
iMesh_setDblArrData** : tag_values_size
iMesh_setEHArrData** : tag_values_size
iMesh_getData** : tag_value_size
iMesh_setData** : tag_value_size
* Do we want to change the vertex coordinate functions? The
caller can determine the number of coordinate values as the
number of vertices times the geometric dimension.
** Do we want to change the tag data functions? The caller
can determine the size by querying the tag size and multiplying
by the number of entities.
Also, should we remove the *_allocated argument corresponding to each of the
*_size arguments listed above? It is unnecessary. For the two cases:
a) Caller passes in NULL pointer
- implementation allocates array
- allocated size is always the same as occupied size (which the
caller knows)
b) Caller passes in non-NULL pointer
- implementation copies data into passed array
- caller already knows the required size for the array
Of course, if the caller already knows the size I wonder why we need to
offer the option of allocating the array at all. If the caller wants it
allocated they can do so themselves, as they're responsible for freeing it
anyway.
- jason
--
"A foolish consistency is the hobgoblin of little minds" - Ralph Waldo Emerson
More information about the itaps-parallel
mailing list