itaps-parallel technical issues in iMeshP.h
Jason Kraftcheck
kraftche at cae.wisc.edu
Thu Oct 2 16:46:01 CDT 2008
iMeshP_createPartitionAll
- Why MPI_Comm*? It is an "in" argument. Pass by value would
be better, but if passed by pointer is desired for some reason
it should be const.
iMeshP_destroyPartitionAll
- Why is 'partition_handle' inout? What is this function returning
a handle to? Some other partition?
- Why the "All" in the name? It isn't destroying all partitions,
just the passed one. Presumably in the previous function 'All'
means the 'Mesh', but unless where destroying the Mesh in this function
it doesn't make sense from a consistency POV either.
iMeshP_getPartFromPartHandle
iMeshP_getPartFromPartHandlesArr
iMeshP_getPartHandleFromPart
iMeshP_getPartHandlesFromPartsArr
- Should these be iMeshP_getPartIdFromPartHandle(sArr)
^^
and iMeshP_getPartHandleFromPartId(sArr) ?
^^
void iMeshP_iPushTagsEnt
- If 'entities' is an input, it should be const.
iMeshP_ghostEntInfo
- 'num_ghost_rules" is not documented with other parameters
- 'num_ghost_rules" type is inconsistent with 'out' designator
More information about the itaps-parallel
mailing list