[Darshan-commits] [Git][darshan/darshan][master] 2 commits: MAINT: rm pass statements

[Shane Snyder]

Shane Snyder pushed to branch master at darshan / darshan


Commits:
ce78d6b2 by Tyler Reddy at 2021-04-15T16:49:28-06:00
MAINT: rm pass statements

* `darshan/report.py` contains many pointless `pass`
statements; they may have served a placeholding purpose
early in development, but they are no longer of any use
so remove them

- - - - -
e930ea08 by Shane Snyder at 2021-05-11T14:37:00-05:00
Merge branch 'treddy_rm_pass_darshan_report' into 'master'

MAINT: rm pass statements

See merge request darshan/darshan!99
- - - - -


1 changed file:

- darshan-util/pydarshan/darshan/report.py


Changes:

=====================================
darshan-util/pydarshan/darshan/report.py
=====================================
@@ -66,7 +66,6 @@ class DarshanRecordCollection(collections.abc.MutableSequence):
 
         self._type = "collection"  # collection => list(), single => [record], nested => [[], ... ,[]]
         self._records = list()     # internal format before user conversion
-        pass
     
     def __len__(self):
         return len(self._records)
@@ -224,7 +223,6 @@ class DarshanRecordCollection(collections.abc.MutableSequence):
         elif mod in ['DXT_POSIX', 'DXT_MPIIO']:
             # format already in a dict format, but may offer switches for expansion
             logger.warn("WARNING: The output of DarshanRecordCollection.to_dict() may change in the future.")
-            pass
         else:
             for i, rec in enumerate(records):
                 rec['counters'] = dict(zip(counters['counters'], rec['counters']))
@@ -549,7 +547,6 @@ class DarshanReport(object):
         for mod in self.data['modules']:
             self.mod_read_all_records(mod, dtype=dtype, warnings=False)
 
-        pass
 
 
     def read_all_dxt_records(self, reads=True, writes=True, dtype=None):
@@ -568,7 +565,6 @@ class DarshanReport(object):
         for mod in self.data['modules']:
             self.mod_read_all_dxt_records(mod, warnings=False, reads=reads, writes=writes, dtype=dtype)
 
-        pass
 
 
     def mod_read_all_records(self, mod, dtype=None, warnings=True):
@@ -648,7 +644,6 @@ class DarshanReport(object):
                 'fcounters': combined_fc
                 }]
 
-        pass
 
     def mod_read_all_apmpi_records(self, mod="APMPI", dtype=None, warnings=True):
         """ 
@@ -699,7 +694,6 @@ class DarshanReport(object):
         if self.lookup_name_records:
             self.update_name_records()
 
-        pass
 
     def mod_read_all_apxc_records(self, mod="APXC", dtype=None, warnings=True):
         """ 
@@ -749,7 +743,6 @@ class DarshanReport(object):
         if self.lookup_name_records:
             self.update_name_records()
 
-        pass
 
     def mod_read_all_dxt_records(self, mod, dtype=None, warnings=True, reads=True, writes=True):
         """
@@ -803,7 +796,6 @@ class DarshanReport(object):
         if self.lookup_name_records:
             self.update_name_records()
 
-        pass
 
 
 
@@ -882,7 +874,6 @@ class DarshanReport(object):
                 'counters': combined_c,
                 }]
 
-        pass
 
 
 



View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/compare/feff6be89f26e5fb40bba576213612b9804f1d8a...e930ea08832c47711423345470a4b82b644b3db9

-- 
View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/compare/feff6be89f26e5fb40bba576213612b9804f1d8a...e930ea08832c47711423345470a4b82b644b3db9
You're receiving this email because of your account on xgitlab.cels.anl.gov.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/darshan-commits/attachments/20210511/fac9027b/attachment-0001.html>