[Darshan-commits] [Git][darshan/darshan][master] 3 commits: clarify comments and configure help for max mem

[Philip Carns]

Philip Carns pushed to branch master at darshan / darshan


Commits:
4cac1e1e by Phil Carns at 2021-03-11T16:59:17-05:00
clarify comments and configure help for max mem

- - - - -
117568d3 by Phil Carns at 2021-03-11T16:59:55-05:00
boost default per-process memory limit to 4 MiB

- - - - -
4f87238e by Philip Carns at 2021-03-11T16:01:31-06:00
Merge branch 'carns/issue-290-maxmem' into 'master'

increase max memory per process

Closes #290

See merge request darshan/darshan!83
- - - - -


4 changed files:

- darshan-runtime/configure
- darshan-runtime/configure.in
- darshan-runtime/darshan-core.h
- darshan-runtime/darshan-runtime-config.h.in


Changes:

=====================================
darshan-runtime/configure
=====================================
@@ -1398,7 +1398,8 @@ Optional Packages:
   --with-jobid-env=<name> Name of environment variable that stores the jobid
                           (specify "NONE" if no appropriate environment variable
                           is available: Darshan will use the pid of rank 0)
-  --with-mod-mem=<num>    Maximum amount of memory (in MiB) for each Darshan module
+  --with-mod-mem=<num>    Maximum runtime memory consumption per process
+                          (in MiB) across all instrumentation modules
 
 Some influential environment variables:
   MPICC       MPI C compiler command
@@ -4188,7 +4189,8 @@ else
 fi
 
 if test "x$enable_hdf5_mod" != "xno"; then :
-  if test -d "$enable_hdf5_mod"; then :
+
+    if test -d "$enable_hdf5_mod"; then :
   CFLAGS="${CFLAGS} -I${enable_hdf5_mod}/include"
         DARSHAN_HDF5_LD_FLAGS="-L${enable_hdf5_mod}/lib -Wl,-rpath=${enable_hdf5_mod}/lib -lhdf5"
 else


=====================================
darshan-runtime/configure.in
=====================================
@@ -166,11 +166,12 @@ AC_ARG_WITH(jobid-env,
 )
 
 AC_ARG_WITH(mod-mem,
-[  --with-mod-mem=<num>    Maximum amount of memory (in MiB) for each Darshan module],
+[  --with-mod-mem=<num>    Maximum runtime memory consumption per process
+                          (in MiB) across all instrumentation modules],
     if test x$withval = xyes; then
         AC_MSG_ERROR(--with-mod-mem must be given a number)
     else
-        AC_DEFINE_UNQUOTED(__DARSHAN_MOD_MEM_MAX, ${withval}, Maximum memory (in MiB) for each Darshan module)
+        AC_DEFINE_UNQUOTED(__DARSHAN_MOD_MEM_MAX, ${withval}, Maximum runtime memory consumption per process (in MiB) across all instrumentation modules)
     fi
 )
 


=====================================
darshan-runtime/darshan-core.h
=====================================
@@ -48,11 +48,13 @@
 #define DARSHAN_DEF_MMAP_LOG_PATH "/tmp"
 #endif
 
-/* Maximum amount of memory per instrumentation module in MiB */
+/* Maximum runtime memory consumption per process (in MiB) across
+ * all instrumentation modules
+ */
 #ifdef __DARSHAN_MOD_MEM_MAX
 #define DARSHAN_MOD_MEM_MAX (__DARSHAN_MOD_MEM_MAX * 1024L * 1024L)
 #else
-#define DARSHAN_MOD_MEM_MAX (2 * 1024 * 1024) /* 2 MiB default */
+#define DARSHAN_MOD_MEM_MAX (4 * 1024 * 1024) /* 2 MiB default */
 #endif
 
 /* default name record buf can store 2048 records of size 100 bytes */


=====================================
darshan-runtime/darshan-runtime-config.h.in
=====================================
@@ -135,7 +135,8 @@
 /* Memory alignment in bytes */
 #undef __DARSHAN_MEM_ALIGNMENT
 
-/* Maximum memory (in MiB) for each Darshan module */
+/* Maximum runtime memory consumption per process (in MiB) across all
+   instrumentation modules */
 #undef __DARSHAN_MOD_MEM_MAX
 
 /* Generalized request type for MPI-IO */



View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/compare/8f4cdc1cd2d33e63aa85bf513f9e91246aea68c2...4f87238eb0e3899a203b5390784376819a05d47f

-- 
View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/compare/8f4cdc1cd2d33e63aa85bf513f9e91246aea68c2...4f87238eb0e3899a203b5390784376819a05d47f
You're receiving this email because of your account on xgitlab.cels.anl.gov.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/darshan-commits/attachments/20210311/846ae6e4/attachment-0001.html>