[Darshan-commits] [Git][darshan/darshan][autoperf-mod-update] 2 commits: code cleanup - remove comments
Sudheer Chunduri
xgitlab at cels.anl.gov
Fri Jan 22 16:48:38 CST 2021
Sudheer Chunduri pushed to branch autoperf-mod-update at darshan / darshan
Commits:
96abb6b8 by Sudheer Chunduri at 2021-01-22T22:47:18+00:00
code cleanup - remove comments
- - - - -
61583cab by Sudheer Chunduri at 2021-01-22T22:48:19+00:00
Merge branch 'autoperf-mod-update' of https://xgitlab.cels.anl.gov/darshan/darshan into autoperf-mod-update
- - - - -
2 changed files:
- darshan-runtime/lib/darshan-core.c
- modules/autoperf
Changes:
=====================================
darshan-runtime/lib/darshan-core.c
=====================================
@@ -521,7 +521,9 @@ void darshan_core_shutdown()
/* get a list of records which are shared across all processes */
darshan_get_shared_records(final_core, &shared_recs, &shared_rec_cnt);
+#if 0
printf(" L 524 --- my_rank: %d shared_rec_cnt: %d\n", my_rank, shared_rec_cnt);
+#endif
mod_shared_recs = malloc(shared_rec_cnt * sizeof(darshan_record_id));
assert(mod_shared_recs);
}
@@ -592,8 +594,9 @@ void darshan_core_shutdown()
{
mod_buf = final_core->mod_array[i]->rec_buf_start;
mod_buf_sz = final_core->mod_array[i]->rec_buf_p - mod_buf;
-
+#if 0
printf("l 596 --- MOD_ID: %d my_rank: %d mod_buf_sz: %d\n", i, my_rank, mod_buf_sz);
+#endif
#ifdef HAVE_MPI
if(using_mpi)
@@ -608,13 +611,17 @@ void darshan_core_shutdown()
HASH_FIND(hlink, final_core->name_hash, &shared_recs[j],
sizeof(darshan_record_id), ref);
assert(ref);
+#if 0
printf("l 611 --- MOD_ID: %d my_rank: %d j: %d ref->mod_flags: %d ref->global_mod_flags: %d \n", i, my_rank, j, ref->mod_flags, ref->global_mod_flags );
+#endif
if(DARSHAN_MOD_FLAG_ISSET(ref->global_mod_flags, i))
{
mod_shared_recs[mod_shared_rec_cnt++] = shared_recs[j];
}
}
+#if 0
printf("l 617 --- MOD_ID: %d my_rank: %d shared_rec_cnt:%d mod_shared_rec_cnt:%d\n", i, my_rank, shared_rec_cnt, mod_shared_rec_cnt);
+#endif
/* int comm_size;
MPI_Comm_size(final_core->mpi_comm, &comm_size);
@@ -622,7 +629,9 @@ void darshan_core_shutdown()
int name_length;
MPI_Comm_get_name(final_core->mpi_comm, name, &name_length);
*/
+#if 0
printf("l 624 --- MOD_ID: %d my_rank: %d DARSHAN_DISABLE_SHARED_REDUCTION:%d \n", i, my_rank, getenv("DARSHAN_DISABLE_SHARED_REDUCTION"));
+#endif
/* allow the module an opportunity to reduce shared files */
if(this_mod->mod_funcs.mod_redux_func && (mod_shared_rec_cnt > 0) &&
(!getenv("DARSHAN_DISABLE_SHARED_REDUCTION"))){
@@ -1227,7 +1236,9 @@ static int darshan_add_name_record_ref(struct darshan_core_runtime *core,
ref->name_record->id = rec_id;
strcpy(ref->name_record->name, name);
DARSHAN_MOD_FLAG_SET(ref->mod_flags, mod_id);
+#if 0
printf(" L 1230 ---- my_rank:%d mod_id: %d name: %s ref->mod_flags: %d ref->global_mod_flags:%d \n", my_rank, mod_id, name, ref->mod_flags, ref->global_mod_flags);
+#endif
/* add the record to the hash table */
HASH_ADD(hlink, core->name_hash, name_record->id,
sizeof(darshan_record_id), ref);
@@ -1291,7 +1302,9 @@ static void darshan_get_shared_records(struct darshan_core_runtime *core,
/* broadcast root's number of records to all other processes */
PMPI_Bcast(&tmp_cnt, 1, MPI_INT, 0, core->mpi_comm);
+#if 0
printf("L 1294 --- my_rank: %d core->name_hash: %lu tmp_cnt: %d\n", my_rank, core->name_hash, tmp_cnt);
+#endif
/* use root record count to allocate data structures */
id_array = malloc(tmp_cnt * sizeof(darshan_record_id));
mod_flags = malloc(tmp_cnt * sizeof(uint64_t));
@@ -1326,7 +1339,9 @@ static void darshan_get_shared_records(struct darshan_core_runtime *core,
/* we opened that record too, save the mod_flags */
mod_flags[i] = ref->mod_flags;
}
+#if 0
printf(" --- L 1329 my_rank: %d mod_flags[%d]: %d \n", my_rank, i, mod_flags[i]);
+#endif
}
/* now allreduce so everyone agrees which records are shared and
@@ -1338,7 +1353,9 @@ static void darshan_get_shared_records(struct darshan_core_runtime *core,
j = 0;
for(i=0; i<tmp_cnt; i++)
{
+#if 0
printf(" --- L 1341 my_rank: %d mod_flags[%d]: %d global_mod_flags[%d]: %d\n", my_rank, i, mod_flags[i], i, global_mod_flags[i]);
+#endif
if(global_mod_flags[i] != 0)
{
(*shared_recs)[j++] = id_array[i];
@@ -1350,7 +1367,9 @@ static void darshan_get_shared_records(struct darshan_core_runtime *core,
HASH_FIND(hlink, core->name_hash, &id_array[i], sizeof(darshan_record_id), ref);
assert(ref);
ref->global_mod_flags = global_mod_flags[i];
+#if 0
printf(" L 1351 --- i: %d ref->mod_flags: %d ref->global_mod_flags: %d\n", i, ref->mod_flags, ref->global_mod_flags);
+#endif
}
}
*shared_rec_cnt = j;
@@ -2286,8 +2305,10 @@ void *darshan_core_register_record(
DARSHAN_CORE_UNLOCK();
return(NULL);
}
+#if 0
printf("L 2289 --- my_rank: %d mod_id: %d name: %s \n\n\n\n\n\n\n\n\n\n\n", my_rank, mod_id, name);
printf("L 2286 --- my_rank: %d mod_id: %d darshan_core->mod_array[mod_id]->rec_mem_avail: %d rec_len:%d \n", my_rank, mod_id, darshan_core->mod_array[mod_id]->rec_mem_avail, rec_len);
+#endif
/* check to see if this module has enough space to store a new record */
if(darshan_core->mod_array[mod_id]->rec_mem_avail < rec_len)
{
@@ -2304,10 +2325,14 @@ void *darshan_core_register_record(
*/
HASH_FIND(hlink, darshan_core->name_hash, &rec_id,
sizeof(darshan_record_id), ref);
+#if 0
printf("L 2303 --- my_rank: %d rec_id: %d ref: %d darshan_core->name_hash: %d \n", my_rank, rec_id, ref, darshan_core->name_hash);
+#endif
if(!ref)
{
+#if 0
printf(" 2306 --- my_rank:%d mod_id: %d, rec_id: %lu name: %s \n", my_rank, mod_id, rec_id, name );
+#endif
ret = darshan_add_name_record_ref(darshan_core, rec_id, name, mod_id);
if(ret == 0)
{
@@ -2315,7 +2340,9 @@ void *darshan_core_register_record(
DARSHAN_CORE_UNLOCK();
return(NULL);
}
+#if 0
printf(" 2314 --- my_rank: %d mod_id: %d ret: %d\n", my_rank, mod_id, ret);
+#endif
}
else
{
=====================================
modules/autoperf
=====================================
@@ -1 +1 @@
-Subproject commit 5f40cfef242df9463ea877be852fbfff97e0191b
+Subproject commit a04747faf378cb5cc6a321769f1d0d2dd6b9596d
View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/compare/02322dc60d705d5531e8f2431e0d84dbf007a588...61583cab610be6dc8bca12bb9aa3a325406a4a77
--
View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/compare/02322dc60d705d5531e8f2431e0d84dbf007a588...61583cab610be6dc8bca12bb9aa3a325406a4a77
You're receiving this email because of your account on xgitlab.cels.anl.gov.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/darshan-commits/attachments/20210122/82ca88f7/attachment-0001.html>
More information about the Darshan-commits
mailing list