[Darshan-commits] [Git][darshan/darshan][master] 2 commits: check lustre striping for all files

[Shane Snyder]

Shane Snyder pushed to branch master at darshan / darshan


Commits:
8b3771d4 by Shane Snyder at 2021-04-29T18:02:50+00:00
check lustre striping for all files

This attempts to work around issue #302, where Darshan can't
instrument Lustre striping information for symlinks to Lustre
files that reside on other file systems. The method for querying
Lustre striping info is general enough (based on xattrs) and
low-overhead enough that this should not create any issues for
Darshan users.

Closes #302

- - - - -
5ec3e5a9 by Shane Snyder at 2021-04-29T13:41:59-05:00
Merge branch 'snyder/dev-issue302-lustre-symlinks' into 'master'

check lustre striping for all files

Closes #302

See merge request darshan/darshan!108
- - - - -


1 changed file:

- darshan-runtime/lib/darshan-core.c


Changes:

=====================================
darshan-runtime/lib/darshan-core.c
=====================================
@@ -2342,8 +2342,16 @@ char *darshan_core_lookup_record_name(darshan_record_id rec_id)
 void darshan_instrument_fs_data(int fs_type, const char *path, int fd)
 {
 #ifdef DARSHAN_LUSTRE
-    /* allow lustre to generate a record if we configured with lustre support */
-    if(fs_type == LL_SUPER_MAGIC)
+    /* allow Lustre to generate a record if we configured with Lustre support */
+    /* XXX: Note that we short-circuit this Lustre file system check and try to
+     * query Lustre striping stats for *all* files instrumented by Darshan (i.e.,
+     * Lustre files or not). We do this so that symlinks to Lustre files are
+     * properly instrumented, since these symlinks might live on other non-Lustre
+     * file systems. We have instrumented this Lustre file system check on a number
+     * of file systems and believe it is low overhead enough to not be noticable by
+     * users.
+     */
+    if(1 || fs_type == LL_SUPER_MAGIC)
     {
         darshan_instrument_lustre_file(path, fd);
         return;



View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/compare/95678e943cfdafab39b8ba549dfa5775bf938e5c...5ec3e5a9f5ce4be7faddc266ee18c8db0d2cf5bc

-- 
View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/compare/95678e943cfdafab39b8ba549dfa5775bf938e5c...5ec3e5a9f5ce4be7faddc266ee18c8db0d2cf5bc
You're receiving this email because of your account on xgitlab.cels.anl.gov.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/darshan-commits/attachments/20210429/3e0de1a1/attachment.html>