[Darshan-commits] [Git][darshan/darshan][carns/dev-warnings] clean up warnings in darshan-util

[Philip Carns]

Philip Carns pushed to branch carns/dev-warnings at darshan / darshan


Commits:
81b266b8 by Phil Carns at 2020-11-30T14:50:10-05:00
clean up warnings in darshan-util

- nothing important, just cutting down noise

- - - - -


2 changed files:

- darshan-util/darshan-hdf5-logutils.c
- darshan-util/darshan-logutils.c


Changes:

=====================================
darshan-util/darshan-hdf5-logutils.c
=====================================
@@ -224,14 +224,18 @@ static int darshan_log_get_hdf5_dataset(darshan_fd fd, void** hdf5_buf_p)
     {
         fprintf(stderr, "Error: Invalid H5D module version number (got %d)\n",
             fd->mod_ver[DARSHAN_H5D_MOD]);
-        return(-1);
+        ret = -1;
+        goto exit;
     }
 
     if(*hdf5_buf_p == NULL)
     {
         ds = malloc(sizeof(*ds));
         if(!ds)
-            return(-1);
+        {
+            ret = -1;
+            goto exit;
+        }
     }
 
     if(fd->mod_ver[DARSHAN_H5D_MOD] == DARSHAN_H5D_VER)


=====================================
darshan-util/darshan-logutils.c
=====================================
@@ -2097,7 +2097,6 @@ void darshan_log_get_name_records(darshan_fd fd,
 {
     int ret;
     struct darshan_name_record_ref *name_hash = NULL;
-    struct darshan_name_record_ref *ref = NULL;
     struct darshan_name_record_ref *tmp = NULL;
     struct darshan_name_record_ref *curr = NULL;
 
@@ -2140,7 +2139,6 @@ void darshan_log_get_filtered_name_records(darshan_fd fd,
 
     int ret;
     struct darshan_name_record_ref *name_hash = NULL;
-    struct darshan_name_record_ref *ref = NULL;
     struct darshan_name_record_ref *tmp = NULL;
     struct darshan_name_record_ref *curr = NULL;
 



View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/commit/81b266b8049429670da40972b749cb21d473cd66

-- 
View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/-/commit/81b266b8049429670da40972b749cb21d473cd66
You're receiving this email because of your account on xgitlab.cels.anl.gov.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/darshan-commits/attachments/20201130/6729d1ca/attachment-0001.html>