[Darshan-commits] [Git][darshan/darshan][carns/dev-dyn-link-updates] update comments

[Philip Carns]

Philip Carns pushed to branch carns/dev-dyn-link-updates at darshan / darshan


Commits:
fb87d7c6 by Phil Carns at 2020-03-20T09:18:48-04:00
update comments

- - - - -


1 changed file:

- darshan-runtime/darshan-gen-cc.pl.in


Changes:

=====================================
darshan-runtime/darshan-gen-cc.pl.in
=====================================
@@ -237,10 +237,13 @@ print OUTPUT<<"EOF";
 
     used_darshan=0
 
-    # Trial run to generate a symbol listing.  We only enable Darshan if MPI
-    # symbols are present. Technically Darshan should not harm
-    # non-MPI programs, but it may bring in unwanted dependencies or
-    # interfere with autoconf checks.
+    # Perform a test link before the real link.  This allows us to check
+    # for two things:
+    # 1) Are MPI symbols present? Technically Darshan should not harm
+    #    non-MPI programs, but it may bring in unwanted dependencies or
+    #    interfere with autoconf checks.
+    # 2) Is this link command line going to produce a static or dynamic
+    #    linked executable?  We will adjust Darshan link strategy accordingly.
 
     # create a temporary file
     tmpfile=`mktemp`
@@ -268,8 +271,8 @@ print OUTPUT<<"EOF";
     rm \$tmpfile >& /dev/null
     rm \$binfile >& /dev/null
 
-    # disable darshan if the executable is not an MPI program (this feature
-    # mainly allows runtime configure tests to work
+    # disable darshan if the executable is not an MPI program or we've
+    # detected an incompatible compiler
     if [ \$rc_mpi -eq 0 ] && [ \$compiler_check -eq 0 ]; then
         if [ \$rc_dyn -eq 0 ]; then
             \$Show \$CC $link_cmd_prefix $dyn_link_cmd_suffix



View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/commit/fb87d7c66702d86e1a488267ebc92e5b05a73074

-- 
View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/commit/fb87d7c66702d86e1a488267ebc92e5b05a73074
You're receiving this email because of your account on xgitlab.cels.anl.gov.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/darshan-commits/attachments/20200320/96fc9513/attachment.html>