[Darshan-commits] [Git][darshan/darshan][master] 2 commits: silence stdout from job-summary

[Shane Snyder]

Shane Snyder pushed to branch master at darshan / darshan


Commits:
f37ffc8d by Philip Carns at 2020-04-26T16:45:37-05:00
silence stdout from job-summary

- also remove --summary option
- closes #264

- - - - -
2e7a7a00 by Shane Snyder at 2020-04-26T16:45:38-05:00
Merge branch 'carns/issue-264-silence-summary' into 'master'

silence stdout from job-summary

Closes #264

See merge request darshan/darshan!50
- - - - -


2 changed files:

- ChangeLog
- darshan-util/darshan-job-summary/bin/darshan-job-summary.pl.in


Changes:

=====================================
ChangeLog
=====================================
@@ -2,6 +2,10 @@
 Darshan Release Change Log
 --------------------------
 
+Darshan-3.2.0-pre2
+=============
+* silence stdout from darshan-job-summary.pl and remove --summary option
+
 Darshan-3.2.0-pre1
 =============
 * corrected pkgconfig path for darshan-util when using DESTDIR (reported by


=====================================
darshan-util/darshan-job-summary/bin/darshan-job-summary.pl.in
=====================================
@@ -32,7 +32,6 @@ my $gnuplot        = "gnuplot";
 my $orig_dir = getcwd;
 my $output_file = "summary.pdf";
 my $verbose_flag = 0;
-my $summary_flag = 0;
 my $input_file = "";
 my %posix_access_hash = ();
 my %mpiio_access_hash = ();
@@ -977,25 +976,6 @@ close VAR_TABLE;
 # calculate performance
 ##########################################################################
 
-# what was the slowest time by any proc for unique file access?
-my $slowest_uniq_time = 0;
-if(keys %hash_unique_file_time > 0)
-{
-    $slowest_uniq_time < $_ and $slowest_uniq_time = $_ for values %hash_unique_file_time;
-}
-print("Slowest unique file time: $slowest_uniq_time\n");
-print("Slowest shared file time: $shared_file_time\n");
-print("Total bytes read and written by app (may be incorrect): $total_job_bytes\n");
-my $tmp_total_time = $slowest_uniq_time+$shared_file_time;
-print("Total absolute I/O time: $tmp_total_time\n");
-print("**NOTE: above shared and unique file times calculated using MPI-IO timers if MPI-IO interface used on a given file, POSIX timers otherwise.\n");
-
-#Exit here if user ask only for a summary
-if ($summary_flag)
-{
-        exit(0);
-}
-
 # move to tmp_dir
 chdir $tmp_dir;
 
@@ -1493,13 +1473,12 @@ sub process_file_record
 
 sub process_args
 {
-    use vars qw( $opt_help $opt_output $opt_verbose $opt_summary);
+    use vars qw( $opt_help $opt_output $opt_verbose);
 
     Getopt::Long::Configure("no_ignore_case", "bundling");
     GetOptions( "help",
         "output=s",
-        "verbose",
-        "summary");
+        "verbose");
 
     if($opt_help)
     {
@@ -1517,11 +1496,6 @@ sub process_args
         $verbose_flag = $opt_verbose;
     }
 
-    if($opt_summary)
-    {
-        $summary_flag = $opt_summary;
-    }
-    
     # there should only be one remaining argument: the input file 
     if($#ARGV != 0)
     {
@@ -1623,8 +1597,7 @@ Usage: $PROGRAM_NAME <options> input_file
 
     --help          Prints this help message
     --output        Specifies a file to write pdf output to
-                    (defaults to ./summary.pdf)
-    --summary       Print a very succinct I/O timing summary and exit
+                    (defaults to ./<input_file>.pdf)
     --verbose       Prints and retains tmpdir used for LaTeX output
 
 Purpose:



View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/compare/8dbe970a19839b6a6683302bcb0c45c7c3d4da6b...2e7a7a003f230fa622ad2c61a0d37ab70d1103f8

-- 
View it on GitLab: https://xgitlab.cels.anl.gov/darshan/darshan/compare/8dbe970a19839b6a6683302bcb0c45c7c3d4da6b...2e7a7a003f230fa622ad2c61a0d37ab70d1103f8
You're receiving this email because of your account on xgitlab.cels.anl.gov.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/darshan-commits/attachments/20200426/b6677e4c/attachment-0001.html>