[cgma-dev] commit/CGM: Jane Hu: Removed duplicate declaration for iGeom_get_adjacent_entities; Added RefVolume to the list for getting dimension 3 or region info for any RefEntity, per Paul's request. Didn't affect make or make check.

[janejhu@gmail.com]

Agreed. I'll check on other locations to adjust this behaviour change.

Jane 

Sent from my Virgin Mobile Android-Powered Device

----- Reply message -----
From: "Tim Tautges" <timothy.tautges at cd-adapco.com>
To: "Jane Hu" <janejhu at gmail.com>
Cc: "CGMA Development" <cgma-dev at mcs.anl.gov>
Subject: [cgma-dev] commit/CGM: Jane Hu: Removed duplicate declaration for iGeom_get_adjacent_entities; Added RefVolume to the list for getting dimension 3 or region info for any RefEntity, per Paul's request. Didn't affect make or make check.
Date: Tue, Jun 17, 2014 12:59 pm


Well, if that's the case, why didn't any other code change in this file?  With this change, I expect some of the 
behavior that uses this function will change, and these changes will be visible to outside apps.  So you've changed 
behavior to some other arbitrary state, apparently to satisfy one application.  I don't think that's justified.

- tim

On 06/17/2014 11:40 AM, Jane Hu wrote:
> This is to provide an interface to access ref-volumes in iGeom, it's not supposed to solve the inconsistency issue which
> Paul agreed that your suggestions will be the best solution. As Paul mentioned, it should be a through discussion about it.
>
> Jane
>
>
> On Tue, Jun 17, 2014 at 11:01 AM, Tim Tautges <timothy.tautges at cd-adapco.com <mailto:timothy.tautges at cd-adapco.com>> wrote:
>
>     Wait a minute - how is this solving the general problem?  This looks like a hack to get one application working as
>     that app desires, with no improvement in consistency.  What's the reasoning for this change?
>
>     - tim
>
>
>     On 06/17/2014 10:30 AM, Bitbucket wrote:
>
>         1 new commit in CGM:
>
>         https://bitbucket.org/__fathomteam/cgm/commits/__73512689d31c/
>         <https://bitbucket.org/fathomteam/cgm/commits/73512689d31c/>
>         Changeset:   73512689d31c
>         Branch:      trunk
>         User:        Jane Hu
>         Date:        2014-06-17 17:30:00
>         Summary:     Removed duplicate declaration for iGeom_get_adjacent_entities; Added RefVolume to the list for
>         getting dimension 3 or region info for any RefEntity, per Paul's request. Didn't affect make or make check.
>
>         Affected #:  1 file
>
>         Repository URL: https://bitbucket.org/__fathomteam/cgm/ <https://bitbucket.org/fathomteam/cgm/>
>
>         --
>
>         This is a commit notification from bitbucket.org <http://bitbucket.org>. You are receiving
>         this because you have the service enabled, addressing the recipient of
>         this email.
>
>
>     --
>     Timothy J. Tautges
>     Manager, Directed Meshing, CD-adapco
>     Phone: 608-354-1459 <tel:608-354-1459>
>     timothy.tautges at cd-adapco.com <mailto:timothy.tautges at cd-adapco.com>
>
>
>
>
> --
> Jane Hu
>
> Asst. Researcher
> Dept. of Engineering Physics
> UW @ Madison
>
> "And we know that for those who love God, that is, for those who are called according to his purpose, all things are
> working together for good." (Romans 8:28)

-- 
Timothy J. Tautges
Manager, Directed Meshing, CD-adapco
Phone: 608-354-1459
timothy.tautges at cd-adapco.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mcs.anl.gov/pipermail/cgma-dev/attachments/20140617/fc66d662/attachment.html>