[cgma-dev] r5380 - cgm/trunk/itaps

[Steve Jackson]

Hi Jane,

iGeom.h is a C header and iGeom is expected to have a native C binding, so the use of 'bool' and of a reference type (bool&) are both out of place and will confuse any library clients implemented in a language other than C++.  If this new function is to be added to iGeom, the output parameter should have type int*.
~S


On Feb 7, 2012, at 12:26 , jiangtao_ma at yahoo.com wrote:

> Author: janehu
> Date: 2012-02-07 12:26:59 -0600 (Tue, 07 Feb 2012)
> New Revision: 5380
> 
> Modified:
>   cgm/trunk/itaps/iGeom.h
>   cgm/trunk/itaps/iGeom_CGMA.cc
> Log:
> Passed the result out for last check-in.
> 
> Modified: cgm/trunk/itaps/iGeom.h
> ===================================================================
> --- cgm/trunk/itaps/iGeom.h	2012-02-07 17:41:06 UTC (rev 5379)
> +++ cgm/trunk/itaps/iGeom.h	2012-02-07 18:26:59 UTC (rev 5380)
> @@ -3977,7 +3977,7 @@
>                           double x,
>                           double y,
>                           double z,
> -                          bool isOn); 
> +                          bool &isOn); 
> #ifdef __cplusplus
> } /* extern "C" */
> #endif
> 
> Modified: cgm/trunk/itaps/iGeom_CGMA.cc
> ===================================================================
> --- cgm/trunk/itaps/iGeom_CGMA.cc	2012-02-07 17:41:06 UTC (rev 5379)
> +++ cgm/trunk/itaps/iGeom_CGMA.cc	2012-02-07 18:26:59 UTC (rev 5380)
> @@ -6278,7 +6278,7 @@
>                         double x,
>                         double y,
>                         double z,
> -                        bool IsOn)
> +                        bool &IsOn)
> {
>   CubitVector position(x,y,z);
>   CubitPointContainment pc;
>