[AG-DEV] hard coded anl.gov addresses in vic and rat

Andrew Danson Andrew.Danson at newcastle.edu.au
Mon May 21 22:16:12 CDT 2012


Hi Everyone,

Just to continue David's efforts I have checked out both vic and rat for similar hard coded references to the anl.gov domain to see if they will require any changes before our June dead line. Upon investigation it appears that we are fortunate that the majority of static references are simply email address information for the authors of the files. 

There are a couple of bits where anl.gov addresses have been hard coded in vic that are in the tcl code. It appears within accessgrid.tcl as part of initialization in the function ag_init_site_map. This function only appears to be used once within the same file in the function ag_init. It looks like it is easy to change and will have a minimum impact if any.

There is another static reference to the anl.gov address within the ui-windows.tcl file as well. Here it appears to be a default setting when no other setting is provided. I'd imagine this shouldn't be a problem as long as none of the other software relies on the defaults when using vic. Again I think this should be easy to change, but may have a greater impact if other software relies on this setting.

I don't really have expertise in tcl, so if there is anyone who can tell us anything more about what kind of problems these few pieces of code may create that would be great.

Following are the results from grep over the source files.

for rat:
dhcp-10-2-101-198:rat andrewdanson$ grep -ir anl.gov * 
auddev_oss.c:			/* Bob Olson <olson at mcs.anl.gov> suggested that their sound card     */
rat-kill.c: * at Argonne National Laboratory at fl-info at mcs.anl.gov or download a 

for the common library:
dhcp-10-2-101-198:common andrewdanson$ grep -ir anl.gov * 
MODS:          by Robert Olson <olson at mcs.anl.gov>.
MODS:1.2.15  - Added SAP/SDP support from Ivan Judson <judson at mcs.anl.gov>
src/.svn/text-base/sap.c.svn-base: * AUTHOR:   Ivan R. Judson  <judson at mcs.anl.gov>
src/.svn/text-base/sap.h.svn-base: * AUTHOR: Ivan R. Judson <judson at mcs.anl.gov> 
src/.svn/text-base/sdp.c.svn-base: * AUTHOR:   Ivan R. Judson  <judson at mcs.anl.gov>
src/.svn/text-base/sdp.h.svn-base: * AUTHOR: Ivan R. Judson <judson at mcs.anl.gov>
src/sap.c: * AUTHOR:   Ivan R. Judson  <judson at mcs.anl.gov>
src/sap.h: * AUTHOR: Ivan R. Judson <judson at mcs.anl.gov> 
src/sdp.c: * AUTHOR:   Ivan R. Judson  <judson at mcs.anl.gov>
src/sdp.h: * AUTHOR: Ivan R. Judson <judson at mcs.anl.gov>

for vic:
dhcp-10-2-101-198:vic andrewdanson$ grep -ir anl.gov * 
CHANGES.html:<LI>Fixed small bug in RTCP code where random offset was added in twice (once in <I>media_ts</I> method and once by external code). Reported by <A HREF="mailto:olson at mcs.anl.gov">Bob Olson</A>. </LI>
CHANGES.html:<LI>cpmsg was causing a call to realloc on every packet rather than only when the work buffer needed to be expanded. Reported by <A HREF="mailto:olson at mcs.anl.gov">Bob Olson</A>. </LI>
CHANGES.html:<LI>Patched memory leak in grabber-plx.cc thanks to <A HREF="mailto:olson at mcs.anl.gov">Bob Olson</A>. </LI>
CHANGES.html:<LI>Added support transmitting a static JPEG image from a file. Contributed by <A HREF="mailto:olson at mcs.anl.gov">Bob Olson</A>. You need to set <I>Vic.stillGrabber</I> to <I>true</I> in order to get a <I>still</I> device in the Device menu-button. When you select this device, a panel will be inserted in the control menu to let you specify the file anme for an RTP/JPEG type-0 frame. This crude interface is currently just for testing. </LI>
CHANGES.html:<LI>Fixed race in window resize code. Reported by Bob Olson (olson at mcs.anl.gov). </LI>
CHANGES.html:</I><LI>Added support for IBM's Ultimedia Video I/O Adaptor under AIX, thanks to Bob Olson (olson at mcs.anl.gov). </LI>
CHANGES.html:<LI>Better handling of -with-* args to configure and a few more fixes for AIX from Bob Olson (olson at mcs.anl.gov). </LI>
CHANGES.html:<LI>Ported to AIX. Patches contributed by Bob Olson (olson at mcs.anl.gov). Bob also supplied patches to bring linux support back in line. </LI>
CHANGES.html:<LI>Fixed bug in net-ip.cc. IPNetwork::open() was returning garbage. Fix from Bob Olson (olson at mcs.anl.gov). </LI></UL>
CHANGES.html:<LI>Fixed bug with switching capture devices when a device was already opened. Fix from Bob Olson (olson at mcs.anl.gov). </LI></UL>
html/.svn/text-base/CHANGES.html.svn-base:Reported by <a href=mailto:olson at mcs.anl.gov>Bob Olson</a>.
html/.svn/text-base/CHANGES.html.svn-base:Reported by <a href=mailto:olson at mcs.anl.gov>Bob Olson</a>.
html/.svn/text-base/CHANGES.html.svn-base:<a href=mailto:olson at mcs.anl.gov>Bob Olson</a>.
html/.svn/text-base/CHANGES.html.svn-base:Contributed by <a href=mailto:olson at mcs.anl.gov>Bob Olson</a>.
html/.svn/text-base/CHANGES.html.svn-base:<li>Fixed race in window resize code.  Reported by Bob Olson (olson at mcs.anl.gov).
html/.svn/text-base/CHANGES.html.svn-base:  Bob Olson (olson at mcs.anl.gov).
html/.svn/text-base/CHANGES.html.svn-base:  more fixes for AIX from Bob Olson (olson at mcs.anl.gov).
html/.svn/text-base/CHANGES.html.svn-base:<li>Ported to AIX.  Patches contributed by Bob Olson (olson at mcs.anl.gov).
html/.svn/text-base/CHANGES.html.svn-base:  Fix from Bob Olson (olson at mcs.anl.gov).
html/.svn/text-base/CHANGES.html.svn-base:  opened.  Fix from Bob Olson (olson at mcs.anl.gov).
html/.svn/text-base/vic.html.svn-base:	<a href=mailto:olson at mcs.anl.gov>Bob Olson</a>
html/CHANGES.html:Reported by <a href=mailto:olson at mcs.anl.gov>Bob Olson</a>.
html/CHANGES.html:Reported by <a href=mailto:olson at mcs.anl.gov>Bob Olson</a>.
html/CHANGES.html:<a href=mailto:olson at mcs.anl.gov>Bob Olson</a>.
html/CHANGES.html:Contributed by <a href=mailto:olson at mcs.anl.gov>Bob Olson</a>.
html/CHANGES.html:<li>Fixed race in window resize code.  Reported by Bob Olson (olson at mcs.anl.gov).
html/CHANGES.html:  Bob Olson (olson at mcs.anl.gov).
html/CHANGES.html:  more fixes for AIX from Bob Olson (olson at mcs.anl.gov).
html/CHANGES.html:<li>Ported to AIX.  Patches contributed by Bob Olson (olson at mcs.anl.gov).
html/CHANGES.html:  Fix from Bob Olson (olson at mcs.anl.gov).
html/CHANGES.html:  opened.  Fix from Bob Olson (olson at mcs.anl.gov).
html/vic.html:	<a href=mailto:olson at mcs.anl.gov>Bob Olson</a>
tcl/.svn/text-base/accessgrid.tcl.svn-base:    ag_site_entry geode.mcs.anl.gov 0
tcl/.svn/text-base/accessgrid.tcl.svn-base:    ag_site_entry jade.mcs.anl.gov 1
tcl/.svn/text-base/accessgrid.tcl.svn-base:    ag_site_entry anl.gov 2
tcl/.svn/text-base/ui-windows.tcl.svn-base:        set v "yukon.mcs.anl.gov/46352"
tcl/accessgrid.tcl:    ag_site_entry geode.mcs.anl.gov 0
tcl/accessgrid.tcl:    ag_site_entry jade.mcs.anl.gov 1
tcl/accessgrid.tcl:    ag_site_entry anl.gov 2
tcl/ui-windows.tcl:        set v "yukon.mcs.anl.gov/46352"
vic.1:Bob Olson (olson at mcs.anl.gov),
video/.svn/text-base/grabber-still.cpp.svn-base: * Contributed by Bob Olson (olson at mcs.anl.gov) September 1995.
video/.svn/text-base/grabber-sunrise.cpp.svn-base: * Contributed by Bob Olson (olson at mcs.anl.gov) September 1995.
video/grabber-still.cpp: * Contributed by Bob Olson (olson at mcs.anl.gov) September 1995.
video/grabber-sunrise.cpp: * Contributed by Bob Olson (olson at mcs.anl.gov) September 1995.




More information about the ag-dev mailing list