[petsc-dev] how did this buggy mess get into master?

[Barry Smith]

  Matt, 

    How could you have moved this into master? The ex2.c example didn't compile for complex and was totally incorrectly formatted. The makefile had missing tabs so the rules runex2_basic and runex2_window didn't even run plus the $ was missing around MPIEXEC so even if they had run they couldn't run plus

   it also appears that runex2_window doesn't even work. 

$ make runex2_window
10,25c10,35
< Vec Object: 2 MPI processes
<   type: mpi
< Process [0]
< 0
< 1
< Process [1]
< 1
< 0
< Vec Object: 2 MPI processes
<   type: mpi
< Process [0]
< 10
< 11
< Process [1]
< 11
< 10
---
> [0]PETSC ERROR: #1 PetscSFBcastBegin_Window() line 495 in /Users/barrysmith/Src/PETSc/src/vec/is/sf/impls/window/sfwindow.c
> [0]PETSC ERROR: #2 PetscSFBcastBegin() line 924 in /Users/barrysmith/Src/PETSc/src/vec/is/sf/interface/sf.c
> [0]PETSC ERROR: #3 main() line 69 in /Users/barrysmith/Src/petsc/src/vec/is/sf/examples/tutorials/ex2.c
> [0]PETSC ERROR: PETSc Option Table entries:
> [1]PETSC ERROR: #1 PetscSFBcastBegin_Window() line 495 in /Users/barrysmith/Src/PETSc/src/vec/is/sf/impls/window/sfwindow.c
> [0]PETSC ERROR: -sf_type window
> [1]PETSC ERROR: #2 PetscSFBcastBegin() line 924 in /Users/barrysmith/Src/PETSc/src/vec/is/sf/interface/sf.c
> [1]PETSC ERROR: #3 main() line 69 in /Users/barrysmith/Src/petsc/src/vec/is/sf/examples/tutorials/ex2.c
> [0]PETSC ERROR: ----------------End of Error Message -------send entire error message to petsc-maint at mcs.anl.gov----------
> [1]PETSC ERROR: PETSc Option Table entries:
> [1]PETSC ERROR: -sf_type window
> [1]PETSC ERROR: ----------------End of Error Message -------send entire error message to petsc-maint at mcs.anl.gov----------
> application called MPI_Abort(MPI_COMM_WORLD, 539079184) - process 0
> [cli_0]: aborting job:
> application called MPI_Abort(MPI_COMM_WORLD, 539079184) - process 0
> application called MPI_Abort(MPI_COMM_WORLD, 270643728) - process 1
> [cli_1]: aborting job:
> application called MPI_Abort(MPI_COMM_WORLD, 270643728) - process 1
> 
> ===================================================================================
> =   BAD TERMINATION OF ONE OF YOUR APPLICATION PROCESSES
> =   PID 7675 RUNNING AT Barrys-MacBook-Pro.local
> =   EXIT CODE: 16
> =   CLEANING UP REMAINING PROCESSES
> =   YOU CAN IGNORE THE BELOW CLEANUP MESSAGES
> ===================================================================================
/Users/barrysmith/Src/petsc/src/vec/is/sf/examples/tutorials
Possible problem with ex2_window, diffs above
=========================================

  I have cleaned up the code in master in commit e669faa but it still means there is a bug (or an error in the example) in master that needs fixing.

  Barry

> 

> commit f0bcadac1e65793affc0f38311a11fa02852c8a6
> Merge: 2ad7bfe 45038af
> Author: Matthew G. Knepley <knepley at gmail.com>
> Date:   Mon Apr 6 09:30:20 2015 -0500
> 
>    Merge branch 'pr255/mapdes/sf-multiple-in-flight/master'
> 
>    * pr255/mapdes/sf-multiple-in-flight/master:
>      SF: fix multiple in flight comm rounds for basic SFType
> 
>