Move src/dm/dmimpl.h to include/private/dmimpl.h?

Barry Smith bsmith at mcs.anl.gov
Thu Nov 6 16:41:48 CST 2008


    Looks like you didn't move the dmimpl.h? Could you do that please?

    Thanks

    Barry


On Nov 6, 2008, at 3:50 PM, Satish Balay wrote:

> Pushed to petsc-dev.
>
> Satish
>
> On Thu, 6 Nov 2008, Barry Smith wrote:
>
>>
>> Satish,
>>
>>   These changes look good. Could you do the updates?
>> Looks like this one MatCreateSchurComplement should also move to  
>> petscksp.h.
>> you have to do manually.
>>
>>  Thanks
>>
>>  Barry
>>
>> On Nov 6, 2008, at 3:12 PM, Jed Brown wrote:
>>
>>> I use DMHEADER and DMOPS() for my own DM implementation.  With the
>>> recent include path modification, I include "../src/dm/dmimpl.h",  
>>> but it
>>> would seem more consistent to put this in include/private.
>>>
>>>
>>> With pedantic warnings, my compiler finds some duplicate  
>>> declarations
>>> which the attached patch removes.  I assume the declaration of
>>> MatCreateSchurComplement should also move to petscksp.h.
>>>
>>> Jed
>>> <duplicates.patch>
>>
>




More information about the petsc-dev mailing list