<div dir="ltr">I like that a lot. I'll try to spin-up a PR (MR on gitlab?) today.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 28, 2020 at 6:42 PM Barry Smith <<a href="mailto:bsmith@petsc.dev">bsmith@petsc.dev</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><div><br></div> Yes, this is a good idea. Simple extension of current code.<div><br></div><div> The command line would then be <div><br></div><div> -snes_converged_reason ::failed</div><div><br></div><div> add in petscviewer.h </div><div><br></div><div> a new PetscViewerFormat PETSC_VIEWER_FAILED, </div><div><br></div><div> add in viewera.c PetscViewerFormats FAILED.</div><div><br></div><div> add in SNESReasonView </div><div><br></div><div> if (snes->reason > 0 && format != PETSC_VIEWER_FAILED) {</div><div><br></div><div> </div><div> Document it in SNESReasonView manual page<br><div> <br><blockquote type="cite"><div>On Jul 28, 2020, at 7:50 PM, Matthew Knepley <<a href="mailto:knepley@gmail.com" target="_blank">knepley@gmail.com</a>> wrote:</div><br><div><div dir="ltr"><div dir="ltr">On Tue, Jul 28, 2020 at 8:09 PM Alexander Lindsay <<a href="mailto:alexlindsay239@gmail.com" target="_blank">alexlindsay239@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">The only slight annoyance with doing this through a PostSolve hook as opposed to a pluggable ReasonView system is that if a user passed `-snes_converged_reason` on the command line, we would get redundant printout from SNESSolve and our PostSolve. Although I suppose we could solve this by intercepting their option, not passing it to PETSc, and then just using that info to control the output from our PostSolve (e.g. if a user passes -snes_converged_reason from the command line, then we should always print the reason, instead of just printing when we don't converge). So maybe the PostSolve will work fine.</div></blockquote><div><br></div><div>Can't you just define another ASCII format that prints what you want for ReasonView?</div><div><br></div><div> Matt</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 28, 2020 at 12:20 PM Barry Smith <<a href="mailto:bsmith@petsc.dev" target="_blank">bsmith@petsc.dev</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><br></div> KPSSetPostSolve(), There is no SNESSetPostSolve() but there could/should be.<div><br></div><div> Barry</div><div><br><div> Note inside the SNESSolve there are a bunch of pre and post hooks, don't get the confused with an outside SNESSetPostSolve()</div><div><br><blockquote type="cite"><div>On Jul 28, 2020, at 1:12 PM, Fande Kong <<a href="mailto:fdkong.jd@gmail.com" target="_blank">fdkong.jd@gmail.com</a>> wrote:</div><br><div><div dir="ltr"><div dir="ltr"><div dir="ltr">One alternative is to support a plugable KSP/SNESReasonView system. We then could hook up KSP/SNESReasonView_MOOSE.</div><div dir="ltr"><br></div><div>We could call our views from SNES/KSP"done"Solve as well if such a system is not affordable. What are the final functions we should call, where we guarantee SNES/KSP is already done? <br></div><div><br></div><div>Thanks,</div><div><br></div><div>Fande,</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 28, 2020 at 12:02 PM Barry Smith <<a href="mailto:bsmith@petsc.dev" target="_blank">bsmith@petsc.dev</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Alex,<br>
<br>
The actual printing is done with SNESReasonView() and KSPReasonView() I would suggest copying those files to Moose with a name change and removing all the code you don't want. Then you can call your versions immediately after SNESSolve() and KSPSolve().<br>
<br>
Barry<br>
<br>
<br>
> On Jul 28, 2020, at 10:43 AM, Alexander Lindsay <<a href="mailto:alexlindsay239@gmail.com" target="_blank">alexlindsay239@gmail.com</a>> wrote:<br>
> <br>
> To help debug the many emails we get about solves that fail to converge, in MOOSE we recently appended `-snes_converged_reason -ksp_converged_reason` for every call to `SNESSolve`. Of course, now we have users complaining about the new text printed to their screens that they didn't have before. Some of them have made a reasonable request to only print the convergence reason when the solve has actually failed to converge. Is there some way we can only print the reason if we've diverged, e.g. if reason < 0 ?<br>
> <br>
> Alex<br>
<br>
</blockquote></div>
</div></blockquote></div><br></div></div></blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><div><br></div><div><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div></div></div></div>
</div></blockquote></div><br></div></div></div></blockquote></div>