<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Excellent! That sounds great. <div class=""><br class=""></div><div class="">Thank you for your response. </div><div class=""><br class=""></div><div class="">Regards, </div><div class=""><br class=""></div><div class="">Mukkund<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 30 Jun 2020, at 23:55, Mark Adams <<a href="mailto:mfadams@lbl.gov" class="">mfadams@lbl.gov</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">You want to make an MR (check to delete branch after merge and squash commits), you can mark as WIP, run the pipeline and after you get it to run clean and merge any comments, umark WIP. If it does not get merged in a few days you could ask Satish.<div class="">Mark</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 30, 2020 at 5:12 PM MUKKUND SUNJII <<a href="mailto:mukkundsunjii@gmail.com" class="">mukkundsunjii@gmail.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class="">Greetings, <div class=""><br class=""></div><div class="">Thank you for your message. </div><div class=""><br class=""></div><div class="">Excellent! Does it suffice to ask for the merge request once I made the necessary additions to ex11.c?</div><div class=""><br class=""></div><div class="">Regards, </div><div class=""><br class=""></div><div class="">Mukkund <br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On 30 Jun 2020, at 19:16, Matthew Knepley <<a href="mailto:knepley@gmail.com" target="_blank" class="">knepley@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none" class=""><div dir="ltr" class="">On Tue, Jun 30, 2020 at 12:56 PM MUKKUND SUNJII <<a href="mailto:mukkundsunjii@gmail.com" target="_blank" class="">mukkundsunjii@gmail.com</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Greetings,<span class=""> </span><br class=""><br class="">I am a master’s student in TU Delft, The Netherlands, and I am carrying out my thesis using the adaptive mesh refinement solver provided in ./ts/tutorials/ex11.c.<span class=""> </span><br class=""><br class="">In the process of my work, I have added a HLL Riemann Solver for the shallow water equation. I had already tested and validated the Riemann Solver using several cases (I am happy to provide a copy of my thesis report). It would indeed be nice to see my work reflected in the current version of ex11.c as an addition to its capability.<span class=""> </span><br class=""><br class="">Furthermore, I had also added a Riemann Solver that contains topography terms and is well-balanced*. The caveat is that I see that there some variations in the well-balancedness when choosing between p4est and Plex DM’s. Perhaps, this could be looked at and fixed in the future.<span class=""> </span><br class=""><br class="">The purpose of this email is to propose the addition of the HLL Riemann Solver for the shallow water equations to ex11.c and perhaps later explore the possibility of adding the Riemann Solver with the bathymetry terms.<span class=""> </span><br class=""><br class="">I have already gone through the CI process instituted by PETSc (previously integrated ./ts/tutorials/ex54.c into the repository with the valuable assistance of Mr. Satish Balay). Hence, I would be more or less familiar with the process.<span class=""> </span><br class=""><br class="">I kindly ask you provide any feedback on this proposition.<span class=""> </span><br class=""></blockquote><div class=""><br class=""></div><div class="">Yes, this sounds great to me.</div><div class=""><br class=""></div><div class=""> Thanks,</div><div class=""><br class=""></div><div class=""> Matt</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Regards,<span class=""> </span><br class=""><br class="">Mukkund Sunjii<span class=""> </span></blockquote></div><br clear="all" class=""><div class=""><br class=""></div>--<span class=""> </span><br class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br class="">-- Norbert Wiener</div><div class=""><br class=""></div><div class=""><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank" class="">https://www.cse.buffalo.edu/~knepley/</a></div></div></div></div></div></div></div></div></div></blockquote></div><br class=""></div></div></blockquote></div>
</div></blockquote></div><br class=""></div></body></html>