<html><body><div style="font-family: arial, helvetica, sans-serif; font-size: 18pt; color: #000000"><div>Did you forget to attach "The nice picture attached"</div><div>Stephen<br data-mce-bogus="1"></div><div><br></div><hr id="zwchr" data-marker="__DIVIDER__"><div data-marker="__HEADERS__"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><b>From: </b>"Stefano Zampini" <stefano.zampini@gmail.com><br><b>To: </b>"petsc-maint" <knepley@gmail.com><br><b>Cc: </b>"imilian hartig" <imilian.hartig@gmail.com>, "PETSc users list" <petsc-users@mcs.anl.gov><br><b>Sent: </b>Thursday, October 25, 2018 4:47:43 PM<br><b>Subject: </b>Re: [petsc-users] Periodic BC in petsc DMPlex / firedrake<br></blockquote></div><div data-marker="__QUOTED_TEXT__"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div dir="ltr"><div dir="ltr">Opened the PR <a href="https://bitbucket.org/petsc/petsc/pull-requests/1203/fix-dump-vtk-field-with-periodic-meshes/diff" target="_blank">https://bitbucket.org/petsc/petsc/pull-requests/1203/fix-dump-vtk-field-with-periodic-meshes/diff</a><br></div></div><br><div class="gmail_quote"><div dir="ltr">Il giorno gio 25 ott 2018 alle ore 17:44 Matthew Knepley <<a href="mailto:knepley@gmail.com" target="_blank">knepley@gmail.com</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Good catch Stefano.<br><div> Matt</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 25, 2018 at 9:36 AM Stefano Zampini <<a href="mailto:stefano.zampini@gmail.com" target="_blank">stefano.zampini@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr">Maybe this is a fix<br><div><div>diff --git a/src/dm/impls/plex/plexvtu.c b/src/dm/impls/plex/plexvtu.c</div><div>index acdea12c2f..1a8bbada6a 100644</div><div>--- a/src/dm/impls/plex/plexvtu.c</div><div>+++ b/src/dm/impls/plex/plexvtu.c</div><div>@@ -465,10 +465,11 @@ PetscErrorCode DMPlexVTKWriteAll_VTU(DM dm,PetscViewer viewer)</div><div> if ((closure[v] >= vStart) && (closure[v] < vEnd)) {</div><div> PetscScalar *xpoint;</div><div> </div><div>- ierr = DMPlexPointLocalRead(dm,v,x,&xpoint);CHKERRQ(ierr);</div><div>+ ierr = DMPlexPointLocalRead(dm,closure[v],x,&xpoint);CHKERRQ(ierr);</div><div> y[cnt + off++] = xpoint[i];</div><div> }</div><div> }</div><div>+ cnt += off;</div><div> ierr = DMPlexRestoreTransitiveClosure(dm, c, PETSC_TRUE, &closureSize, &closure);CHKERRQ(ierr);</div><div> }</div><div> }</div></div><br><div>Max, does this fix your problem? If you confirm, I'll fix this in the maint branch</div><br><div>If I run the below command line with the patch and with snes tutorials ex12 I get the nice picture attached</div><div>$ ./ex12 -quiet -run_type test -interpolate 1 -bc_type dirichlet -petscspace_degree 1 -vec_view vtk:test.vtu:vtk_vtu -f ${PETSC_DIR}/share/petsc/datafiles/meshes/square_periodic.msh -dm_plex_gmsh_periodic -x_periodicity periodic -y_periodicity periodic -dm_refine 4<br></div></div></div></div><br><div class="gmail_quote"><div dir="ltr">Il giorno gio 25 ott 2018 alle ore 15:11 Stefano Zampini <<a href="mailto:stefano.zampini@gmail.com" target="_blank">stefano.zampini@gmail.com</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr">Matt,</div><div dir="ltr"><br></div><div dir="ltr">you can reproduce it via<br><div>$ valgrind ./ex12 -quiet -run_type test -interpolate 1 -bc_type dirichlet -petscspace_degree 1 -vec_view vtk:test.vtu:vtk_vtu -f ${PETSC_DIR}/share/petsc/datafiles/meshes/square_periodic.msh -dm_plex_gmsh_periodic<br></div><br><div>Long time ago I added support for viewing meshes with periodic vertices in the VTK_VTU viewer, but I did not fix the part that writes fields</div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr">Il giorno mer 24 ott 2018 alle ore 21:04 Matthew Knepley <<a href="mailto:knepley@gmail.com" target="_blank">knepley@gmail.com</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Wed, Oct 24, 2018 at 11:36 AM Maximilian Hartig <<a href="mailto:imilian.hartig@gmail.com" target="_blank">imilian.hartig@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><br><div><br><blockquote><div>On 24. Oct 2018, at 12:49, Matthew Knepley <<a href="mailto:knepley@gmail.com" target="_blank">knepley@gmail.com</a>> wrote:</div><br class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550m_1819301664155549261Apple-interchange-newline"><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div class="gmail_quote"><div dir="ltr">On Wed, Oct 24, 2018 at 6:29 AM Lawrence Mitchell <<a href="mailto:wence@gmx.li" target="_blank">wence@gmx.li</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Hi Max,<br><br>(I'm cc'ing in the petsc-users mailing list which may have more advice, if you are using PETSc you should definitely subscribe!<br><br>> On 24 Oct 2018, at 09:27, Maximilian Hartig <<a href="mailto:imilian.hartig@gmail.com" target="_blank">imilian.hartig@gmail.com</a>> wrote:<br>><span class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550m_1819301664155549261Apple-converted-space"> </span><br>> Hello Lawrence,<br>><span class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550m_1819301664155549261Apple-converted-space"> </span><br>> sorry to message you out of the blue. My name is Max and I found your post on GitHub (<a href="https://github.com/firedrakeproject/firedrake/issues/1246" rel="noreferrer" target="_blank">https://github.com/firedrakeproject/firedrake/issues/1246</a><span class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550m_1819301664155549261Apple-converted-space"> </span>) on DMPlex being able to read periodic gmsh files. I am currently trying to do just that (creating a periodic DMPlex mesh with gmsh) in the context of my PhD work. So far I haven’ t found any documentation on the periodic BC’s with DMPlex and gmsh in the official petsc documentation.<span class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550m_1819301664155549261Apple-converted-space"> </span><br>> I was wondering whether you’d be so kind as to point me in a general direction concerning how to achieve this. You seem experienced in using petsc and I would greatly appreciate your help.<span class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550m_1819301664155549261Apple-converted-space"> </span><br><br><br>I think the answer is "it depends". If you're just using DMPlex directly and all the of the functionality with PetscDS, then I /think/ that reading periodic meshes via gmsh (assuming you're using the appropriate gmsh mesh format [v2]) "just works".<br></blockquote><br><div>There are two phases here: topological and geometric. DMPlex represents the periodic topological entity directly. For example, a circle is just a segment with one end hooked to the other. Vertices are not duplicated, or mapped to each other. This makes topology simple and easy to implement. However, then geometry is more complicated. What Plex does is allow coordinates to be represented by a discontinuous field taking values on cells, in addition to vertices. In our circle example, each cells near the cut will have 2 coordinates, one for each vertex, but they will not agree across the cut. If you define a periodic domain, then Plex can construct this coordinate field automatically using DMPlexLocalize(). These DG coordinates are then used by the integration routines.</div></div></div></div></blockquote><br>Ok, I think I understand the concept. DMPlex reads information about both topology and coordinates from the .msh file. Creating a periodic mesh in gmsh then should allow DMPlex to identify the periodic boundaries as the “cut” and build the mesh topology accordingly. Coordinate information is handled separately.</div><div>That means, as Lawrence suggested, building periodic meshes in gmsh and reading them in to petsc’s DMPlex should indeed “just work”. (From the user perspective). The only extra step is to call DMLocalizeCoordinates() after DMPlexReadFromFile(). Sorry to reiterate, I am just trying to make sense of this. <br><blockquote><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">From my side, the issue is to do with mapping that coordinate field into one that I understand (within Firedrake). You may not have this problem.<br></blockquote><br><div>Firedrake uses its own coordinate mapping and integration routines, so they must manage the second part independently. I hope to get change this slightly soon by making the Firedrake representation a DMField, so that it looks the same to Plex.</div><br><div> <span class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550m_1819301664155549261Apple-converted-space"> </span>Thanks,</div><br><div> Matt</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Thanks,<br><br>Lawrence</blockquote></div><br clear="all"><br>--<span class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550m_1819301664155549261Apple-converted-space"> </span><br><div dir="ltr" class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550m_1819301664155549261gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><br><div><a href="https://www.cse.buffalo.edu/~knepley/" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br data-mce-bogus="1"></div></div></div></div></div></div></div></div></div></blockquote><br></div><div><div dir="ltr"></div><blockquote><div dir="ltr">To read periodic meshes from GMSH, you need to use the option -dm_plex_gmsh_periodic and DMPlexCreateFromFile</div></blockquote><br>Ahh, thanks. I was missing the option " -dm_plex_gmsh_periodic “. But using this option I now generate a segmentation fault error when calling VecView() on the solution vector with vtk and hdf5 viewers. Any suggestions?</div></div></blockquote><br><div> Small example? VTK is deprecated. HDF5 should work, although it will require you to have proper coordinates I think. We have to</div><div>think about what you mean. If its for a checkpoint, there is no problem, but for viz, those programs do not understand periodicity. Thus I embed it in a higher dimensional space.</div><br><div> Matt</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><blockquote><div>See src/dm/impls/plex/examples/tests/ex1.c. An example runs</div><br><div>$ ./ex1 -filename ${PETSC_DIR}/share/petsc/datafiles/meshes/cube_periodic_bin.msh -dm_plex_gmsh_periodic -dm_view ::ascii_info_detail -interpolate -test_shape</div><br><div>generating periodic meshes in gmsh may be tricky, Lisandro for sure may advice.</div></blockquote><br></div><div>Thanks,</div><div>Max</div><br></div></blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958m_-5388742668316797550gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><br><div><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div></div></div></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_-8521583234638429408m_5896768757974229930m_3925837018042710958gmail_signature">Stefano</div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_-8521583234638429408m_5896768757974229930gmail_signature">Stefano</div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="m_-8521583234638429408gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><br><div><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div></div></div>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature">Stefano</div><br></blockquote></div></div></body></html>