<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div><br></div><div>An attempt at complete details on making an MR <a href="https://urldefense.us/v3/__https://petsc.org/release/developers/contributing/__;!!G_uCfscf7eWS!a1bbLw5WyJV3J-nT7Z3nTSKwJwV__JByZVLM7gnJkaJ4Te5me2x0zHqnrtQuQ0fcGofdMFdPKiheANeOyPLvqA$">https://petsc.org/release/developers/contributing/</a></div><div><br></div><div>Barry</div><div><br></div><div>MR on improving the details of making an MR are also always welcome :-)</div><div><br></div><div><br></div><div><br id="lineBreakAtBeginningOfMessage"><div><br><blockquote type="cite"><div>On Feb 5, 2025, at 10:05 AM, Matthew Knepley <knepley@gmail.com> wrote:</div><br class="Apple-interchange-newline"><div><div dir="ltr"><div dir="ltr">On Wed, Feb 5, 2025 at 9:52 AM neil liu <<a href="mailto:liufield@gmail.com">liufield@gmail.com</a>> wrote:</div><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><font size="4">Dear developers, </font></div><div dir="ltr"><p><font face="tahoma, sans-serif">I am currently working with MMG in the context of PETSc and have identified a need to modify the existing MMG interface, <code>DMAdaptMetric_Mmg_Plex()</code>, for our use case. Given these requirements, I would like to explore the feasibility of contributing to PETSc to enhance this interface, which has been verified and validated in our research code. </font></p><h3><strong><font face="tahoma, sans-serif">Proposed Modifications:</font></strong></h3><ol><li><p><strong><font face="tahoma, sans-serif">Additional Labels for Physical Entities:</font></strong></p><ul><li><font face="tahoma, sans-serif">In addition to the existing <code>bdLabel</code> and <code>rgLabel</code>, our case requires two additional labels to represent physical vertices and edges within the computational domain (3D).</font></li></ul></li></ol></div></div></div></div></div></div></div></blockquote><div>I am open to this. Can you be more specific about what it means? </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><ol><li><ul><li><font face="tahoma, sans-serif">One approach is to introduce two new parameters in the subroutine’s input list. However, this may require modifications across related components, such as Pragmatic. </font></li></ul></li></ol></div></div></div></div></div></div></div></blockquote><div>This is not a problem. I can modify those. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><ol><li><p><strong><font face="tahoma, sans-serif">Support for Open Boundaries:</font></strong></p><ul><li><font face="tahoma, sans-serif">The current interface does not support open boundaries, a feature available in MMG.</font></li><li><font face="tahoma, sans-serif">As a result, several MMG benchmark cases involving open boundary remeshing cannot be executed within PETSc.</font></li></ul></li></ol></div></div></div></div></div></div></div></blockquote><div>Can you explain what this means? What is an open boundary exactly?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p><font face="tahoma, sans-serif">Would this be a viable contribution to PETSc? If so, I would appreciate any guidance on the best approach to implementing these changes while maintaining compatibility with existing features.</font></p></div></div></div></div></div></div></div></blockquote><div>Yes. Please make a fork of the petsc repo, make a branch with the proposed changes, make an MR for that branch, and add me to your fork (I am knepley on GitLab). I can help you get it going.</div><div><br></div><div> Thanks,</div><div><br></div><div> Matt</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p><font face="tahoma, sans-serif">Looking forward to your thoughts.</font></p><p><font face="tahoma, sans-serif">Best regards,</font></p></div><div dir="ltr"><span style="font-size:large"><br></span></div><div dir="ltr"><span style="font-size:large">Thanks, </span></div><div dir="ltr"><font size="4">Xiaodong </font><br><div><code><font face="arial black, sans-serif"><b></b></font></code></div><div><code><font face="arial black, sans-serif"><b><br></b></font></code></div><div><code><font face="arial black, sans-serif"><b><br></b></font></code></div><div><code><font face="arial black, sans-serif"><br></font></code></div><div><code><font face="arial black, sans-serif"><br></font></code></div><div><br></div><div><code><font face="arial black, sans-serif"><br></font></code></div><div><code><font face="arial black, sans-serif"><br></font></code></div><div><br></div></div></div></div></div></div></div></div>
</blockquote></div><div><br clear="all"></div><div><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><div><br></div><div><a href="https://urldefense.us/v3/__http://www.cse.buffalo.edu/*knepley/__;fg!!G_uCfscf7eWS!ckCV4wedb-tlOiMIwwdrJ8hJmPbjxoiJJVuJx7hov_xJtl2_sNakx4TEtStOUwqJxJKMbXCVXswizQ0r4ZmC$" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div></div></div></div>
</div></blockquote></div><br></div></body></html>