<html><head><meta http-equiv="content-type" content="text/html; charset=us-ascii"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div><br></div> Sorry about this, we'll take a look and get back to you.<div><br></div><div><br><div><br><blockquote type="cite"><div>On Jun 19, 2023, at 4:05 PM, Nabil Abboud via petsc-dev <petsc-dev@mcs.anl.gov> wrote:</div><br class="Apple-interchange-newline"><div><meta charset="UTF-8"><div class="elementToProof" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">Dear all,</div><div class="elementToProof" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;"><br></div><div class="elementToProof ContentPasted0 ContentPasted3" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">We were trying to update the petsc version we use in our code to the version 3.19.1 when we noticed that some of the unit tests in our code started failing. The reason for the failure seems to be due to a change in the linesearch logic of petsc version 3.19.1. In particular, the implementation of the function SNESLineSearchGetTolerances was modified such that maxstep is now scaled with fnorm as shown in the following link <a href="https://gitlab.com/petsc/petsc/-/blob/main/src/snes/linesearch/interface/linesearch.c#L1097" id="LPNoLPOWALinkPreview_3">https://gitlab.com/petsc/petsc/-/blob/main/src/snes/linesearch/interface/linesearch.c#L1097</a></div><div class="_Entity _EType_OWALinkPreview _EId_OWALinkPreview_3 _EReadonly_1" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 18px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"></div><div class="elementToProof" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;"><span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">This change seems to be inconsistent with the way maxstep is being used later on to compute a step size using the l2 line search algorithm, for instance, check the following code </span><a href="https://gitlab.com/petsc/petsc/-/blob/main/src/snes/linesearch/impls/l2/linesearchl2.c#L119" id="LPNoLPOWALinkPreview_1" style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">https://gitlab.com/petsc/petsc/-/blob/main/src/snes/linesearch/impls/l2/linesearchl2.c#L119</a><span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;"> where maxstep is compared to lambda_update and where maxstep is scaled by fnorm whereas lambda_update seems to be a scalar of a different order as computed here </span><a href="https://gitlab.com/petsc/petsc/-/blob/main/src/snes/linesearch/impls/l2/linesearchl2.c#L111" id="LPNoLPOWALinkPreview_2" style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">https://gitlab.com/petsc/petsc/-/blob/main/src/snes/linesearch/impls/l2/linesearchl2.c#L111</a><span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;"> .</span><br></div><div class="elementToProof ContentPasted0 ContentPasted1 ContentPasted2" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">The way this change is reflected in our code is that we were trying to enforce a range for the step size provided by the l2 line search between 0.1 and 1 and now with the new changes in petsc version 3.19.1 the upper limit seems not to hold anymore and we are seeing step sizes larger than 1.</div><div class="elementToProof ContentPasted0 ContentPasted1 ContentPasted2" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;"><br></div><div class="elementToProof ContentPasted0 ContentPasted1 ContentPasted2" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">Thank you in advance for your help.</div><div class="elementToProof ContentPasted0 ContentPasted1 ContentPasted2" style="font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">Best regards,<div>Nabil</div></div></div></blockquote></div><br></div></body></html>