<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 9 Jun 2022, at 4:33 PM, Mark Adams <<a href="mailto:mfadams@lbl.gov" class="">mfadams@lbl.gov</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I rebased over master and now this branch fails source code check:<div class=""><br class=""></div><div class=""><div class="gmail-js-line gmail-log-line" style="box-sizing:border-box;padding:1px 8px 1px 55px;min-height:1.25rem;color:rgb(255,255,255);font-family:Menlo,"DejaVu Sans Mono","Liberation Mono",Consolas,"Ubuntu Mono","Courier New","andale mono","lucida console",monospace;font-size:13px;background-color:rgb(17,17,17)"><span class="gmail-gl-white-space-pre-wrap" style="box-sizing:border-box;white-space:pre-wrap">SETERRQ() with trailing newline ----------------------</span></div><div class="gmail-js-line gmail-log-line" style="box-sizing:border-box;padding:1px 8px 1px 55px;min-height:1.25rem;color:rgb(255,255,255);font-family:Menlo,"DejaVu Sans Mono","Liberation Mono",Consolas,"Ubuntu Mono","Courier New","andale mono","lucida console",monospace;font-size:13px;background-color:rgb(17,17,17)"><a id="gmail-L1346" href="https://gitlab.com/petsc/petsc/-/jobs/2569478894#L1346" class="gmail-d-inline-block gmail-text-right gmail-flex-shrink-0 gmail-gl-link gmail-line-number" style="box-sizing:border-box;color:rgb(102,102,102);text-decoration-line:none;background-color:transparent;font-size:0.875rem;padding:0px 1em 0px 8px;min-width:50px;display:inline-block;text-align:right">1346</a><span class="gmail-gl-white-space-pre-wrap" style="box-sizing:border-box;white-space:pre-wrap">src/ksp/pc/impls/amgx/amgx.cxx:169: SETERRQ(amgx->comm, PETSC_ERR_LIB, "%s\n", msg); \</span></div></div><div class="gmail-js-line gmail-log-line" style="box-sizing:border-box;padding:1px 8px 1px 55px;min-height:1.25rem;color:rgb(255,255,255);font-family:Menlo,"DejaVu Sans Mono","Liberation Mono",Consolas,"Ubuntu Mono","Courier New","andale mono","lucida console",monospace;font-size:13px;background-color:rgb(17,17,17)"><span class="gmail-gl-white-space-pre-wrap" style="box-sizing:border-box;white-space:pre-wrap"><br class=""></span></div><div class=""><br class=""></div><div class="">Any idea how to best fix this?</div></div></div></blockquote><div><br class=""></div><div>That’s pretty self-explanatory: remove the trailing \n in your error message, i.e., "%s".</div><div><br class=""></div><div>Thanks,</div><div>Pierre</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">Thanks</div><div class=""><br class=""></div><div class="">// XXX Need to add call in AmgX API that gracefully destroys everything<br class="">// without abort etc.<br class="">#define PetscCallAmgX(rc) do { \<br class=""> AMGX_RC err = (rc); \<br class=""> char msg[4096]; \<br class=""> switch (err) { \<br class=""> case AMGX_RC_OK: \<br class=""> break; \<br class=""> default: \<br class=""> AMGX_get_error_string(err, msg, 4096); \<br class=""><b class=""> SETERRQ(amgx->comm, PETSC_ERR_LIB, "%s\n", msg); \<br class=""></b> } \<br class="">} while (0)<br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>