<div dir="ltr"><div dir="ltr">On Tue, Nov 23, 2021 at 11:17 AM Barry Smith <<a href="mailto:bsmith@petsc.dev">bsmith@petsc.dev</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><div><br></div> I would normally say make a pull request but they have their own git server that requires you ask them for an account so I suggest posting an issue with your patch.</div></blockquote><div><br></div><div>Also need an account to create an issue :)</div><div><br></div><div> Matt</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><div> Barry</div><div><br><div><br><blockquote type="cite"><div>On Nov 23, 2021, at 10:55 AM, Matthew Knepley <<a href="mailto:knepley@gmail.com" target="_blank">knepley@gmail.com</a>> wrote:</div><br><div><div dir="ltr">This is the same flex problem as I had for c2html, but I was more determined tracking it down this time. The first problem is that we were not renaming in the parser,<div><br></div><div>main *$:/PETSc3/petsc/petsc-dev$ git diff<br>diff --git a/config/BuildSystem/config/packages/PTScotch.py b/config/BuildSystem/config/packages/PTScotch.py<br>index d1c277b6e9f..e046804c17f 100644<br>--- a/config/BuildSystem/config/packages/PTScotch.py<br>+++ b/config/BuildSystem/config/packages/PTScotch.py<br>@@ -70,7 +70,7 @@ class Configure(config.package.Package):<br> if self.libraries.add('-lrt','timer_create'): ldflags += ' -lrt'<br> self.cflags = self.cflags + ' -DCOMMON_RANDOM_FIXED_SEED'<br> # do not use -DSCOTCH_PTHREAD because requires MPI built for threads.<br>- self.cflags = self.cflags + ' -DSCOTCH_RENAME -Drestrict="'+self.compilers.cRestrict+'"'<br>+ self.cflags = self.cflags + ' -DSCOTCH_RENAME -DSCOTCH_RENAME_PARSER -Drestrict="'+self.compilers.cRestrict+'"'<br> # this is needed on the Mac, because common2.c includes common.h which DOES NOT include mpi.h because<br> # SCOTCH_PTSCOTCH is NOT defined above Mac does not know what clock_gettime() is!<br> if self.setCompilers.isDarwin(self.log):<br><div><br></div><div>Second, they were not treating this case completely correctly:</div><div><br></div><div>(93454e8...):/PETSc3/petsc/petsc-dev/arch-master-debug/externalpackages/git.ptscotch/src/libscotch$ git diff HEAD~1<br>diff --git a/src/libscotch/parser_yy.h b/src/libscotch/parser_yy.h<br>index 931315d..95b8160 100644<br>--- a/src/libscotch/parser_yy.h<br>+++ b/src/libscotch/parser_yy.h<br>@@ -62,6 +62,9 @@<br><br> #if ((defined SCOTCH_RENAME_PARSER) || (defined yylex)) /* If prefix renaming */<br> #define scotchyyparse stratParserParse2 /* Parser function name */<br>+#if !defined(yylex)<br>+#define yylex scotchyylex<br>+#endif<br> #ifndef yylval<br> #define yylval SCOTCH_NAME_MACRO3 (scotchyy, SCOTCH_NAME_SUFFIXC, lval) /* It should be Yacc/Bison's job to redefine it!<br> */<br> #endif /* yylval */<br></div><div><br></div><div>How should we go about getting this fix in? Do you need to have our own branch of PTScotch?</div><div><br></div><div> Thanks,</div><div><br></div><div> Matt</div><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><div><br></div><div><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div></div></div></div></div>
</div></blockquote></div><br></div></div></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><div><br></div><div><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div></div></div></div>