<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">Fix is trivial, we just need to replace ‘\n’ with os.linesep everywhere.</div><div class=""><br class=""></div><div class=""><a href="https://docs.python.org/3/library/os.html#os.linesep" class="">https://docs.python.org/3/library/os.html#os.linesep</a></div><div class=""><br class=""></div><div class="">
<div dir="auto" style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div dir="auto" style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div>Best regards,<br class=""><br class="">Jacob Faibussowitsch<br class="">(Jacob Fai - booss - oh - vitch)<br class=""></div></div></div>
</div>
<div><br class=""><blockquote type="cite" class=""><div class="">On Oct 28, 2021, at 08:12, Matthew Knepley <<a href="mailto:knepley@gmail.com" class="">knepley@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I just found a loophole in the test parsing happening here:<div class=""><br class=""></div><div class=""> <a href="https://gitlab.com/petsc/petsc/-/blob/main/config/testparse.py#L530" class="">https://gitlab.com/petsc/petsc/-/blob/main/config/testparse.py#L530</a><br clear="all" class=""><div class=""><br class=""></div><div class="">If your file was produced on Windows (CRLF), then the parsing fails and tests</div><div class="">are silently ignored. This took me some time to find and could be confusing</div><div class="">for others. I think we should either:</div><div class=""><br class=""></div><div class=""> a) Fix the parser to work with CRLF as well</div><div class=""><br class=""></div><div class="">or</div><div class=""><br class=""></div><div class=""> b) Fail immediately for CRLF files</div><div class=""><br class=""></div><div class="">What do you think?</div><div class=""><br class=""></div><div class=""> Thanks,</div><div class=""><br class=""></div><div class=""> Matt</div><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br class="">-- Norbert Wiener</div><div class=""><br class=""></div><div class=""><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank" class="">https://www.cse.buffalo.edu/~knepley/</a><br class=""></div></div></div></div></div></div></div></div></div>
</div></blockquote></div><br class=""></body></html>