<div dir="ltr"><div dir="ltr">On Tue, Mar 16, 2021 at 2:42 PM Jacob Faibussowitsch <<a href="mailto:jacob.fai@gmail.com">jacob.fai@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><blockquote type="cite"><div style="overflow-wrap: break-word;"><div>To me the best solution is to first split the files when possible (it is often not or just too painful) and then adding imports if needed. </div></div></blockquote><div><br></div>I’m not sure I agree. <span style="color:rgb(0,0,0)">Bear in mind my familiarity with fortran is very limited, but to me the “use” statement is similar to #include <header> in C or using namespace xxx in cpp.</span><div><font color="#000000"><span><br></span></font><div>Our fortran interface is not optimal code atm, it’s as if we put a "#include <petscvec.h>” before every Vec function in the C source (assuming include guards are not used). Sure you can fix this by splitting the vec src files in two, but at the end of the day that’s a bandaid solution. I think I can get the import stuff to work reasonably well (a lot of the infrastructure to capture types is already present in the current generatefortranstubs).</div></div></div></blockquote><div><br></div><div>If you can get this to work, we should definitely do it. Was there a question about getting it to work?</div><div><br></div><div> Thanks,</div><div><br></div><div> Matt</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><div><div><div><div><div><div>
<div dir="auto" style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div>Best regards,<br><br>Jacob Faibussowitsch<br>(Jacob Fai - booss - oh - vitch)<br>Cell: (312) 694-3391</div></div>
</div>
<div><br><blockquote type="cite"><div>On Mar 16, 2021, at 12:56, Barry Smith <<a href="mailto:bsmith@petsc.dev" target="_blank">bsmith@petsc.dev</a>> wrote:</div><br><div><div style="overflow-wrap: break-word;"><div><br></div> Jacob,<div><br></div><div> I split the mat definitions in the MR <a href="https://gitlab.com/petsc/petsc/-/merge_requests/3696" target="_blank">https://gitlab.com/petsc/petsc/-/merge_requests/3696</a> and this reduced memory requirements enough to get builds through on some VM that failed previously ran out of memory (with gfortran). </div><div><br></div><div> The petsc*mod.F90 files are all handwritten so it is ok to manually change them with imports if that helps the IBM compiler. To me the best solution is to first split the files when possible (it is often not or just too painful) and then adding imports if needed. </div><div><br></div><div> Note also the MR <a href="https://gitlab.com/petsc/petsc/-/merge_requests/3715/diffs" target="_blank">https://gitlab.com/petsc/petsc/-/merge_requests/3715/diffs</a> which may help a great deal with the IBM compiler or not.</div><div><br></div><div> Thanks</div><div><br></div><div> Barry</div><div><br></div><div><br><div><br><blockquote type="cite"><div>On Mar 16, 2021, at 11:47 AM, Jacob Faibussowitsch <<a href="mailto:jacob.fai@gmail.com" target="_blank">jacob.fai@gmail.com</a>> wrote:</div><br><div><div style="overflow-wrap: break-word;">Ok something I have gotten to work, but only doing things by hand in petscvecmod.F90:<div><br></div><div>diff --git a/src/vec/f90-mod/petscvecmod.F90 b/src/vec/f90-mod/petscvecmod.F90<br>index 0c447156b9..ef3e2e2e55 100644<br>--- a/src/vec/f90-mod/petscvecmod.F90<br>+++ b/src/vec/f90-mod/petscvecmod.F90<br></div><div> module petscisdef<br> use petscisdefdummy<br> interface operator(.ne.)</div><div> function isnotequal(A,B)<br>- use petscisdefdummy</div><div>+ import tIS<br> logical isnotequal <br> type(tIS), intent(in) :: A,B<br> end function isnotequal<br><div><br></div><div>This works for everything wrapped in a module which contains an interface block. For dangling functions the following works:</div><div><br></div><div> function isnotequal(A,B)</div><div>- use petscisdefdummy</div><div>+ use petscisdef, only: tIs<br> logical isnotequal<br> type(tIS), intent(in) :: A,B<br> isnotequal = (A%v .ne. B%v)<br> end function isnotequal</div><div><br></div><div>Do our fortran stub generators have any notion of types? Specifically types that originate from petsc?</div><div><br></div><div><div>
<div dir="auto" style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div>Best regards,<br><br>Jacob Faibussowitsch<br>(Jacob Fai - booss - oh - vitch)<br>Cell: (312) 694-3391</div></div>
</div>
<div><br><blockquote type="cite"><div>On Mar 16, 2021, at 11:11, Satish Balay <<a href="mailto:balay@mcs.anl.gov" target="_blank">balay@mcs.anl.gov</a>> wrote:</div><br><div><div>On Tue, 16 Mar 2021, Jacob Faibussowitsch wrote:<br><br><blockquote type="cite"><blockquote type="cite">My [partial] change is in branch balay/reorg-f90-for-xlf<br></blockquote><br>Satish is this branch pushed? I’d like to send it to the ibm folks to see if it works for them as well.<br></blockquote><br>Sorry - pushed now. From what I remember - it didn't work.<br><br>Satish<br><br><br><blockquote type="cite">They also added this extra follow up:<br><br>The change we did in the source files is to replace all the "use pet*" statements in all the Interface blocks with IMPORT statement.<br><br>The nature of this workaround is to reduce the number of symbols that the compiler have to create, which exceeded the limitation and caused ICE.<br><br>Every USE statement in an interface block opens up the module symbol file and reads all the symbols from it and creates an entity for each symbol in compiler. This is unnecessary when the module already has the same USE statement in the module scope. Instead, users can use IMPORT statement to make the module symbols accessible inside interface face blocks.<br><br>With the change, the compiler would only read the module symbol file once and create one set of symbols where the old code reads the module symbol files as many times as the number of the USE statements in Interface blocks and create that many sets of duplicate symbols. Replacing those USE statements with IMPORT statements also shortens the compile time significantly.<br><br>Best regards,<br><br>Jacob Faibussowitsch<br>(Jacob Fai - booss - oh - vitch)<br>Cell: (312) 694-3391<br><br><blockquote type="cite">On Mar 3, 2021, at 13:43, Satish Balay via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank">petsc-dev@mcs.anl.gov</a>> wrote:<br><br>The only change I can get working (i.e avoid compile errors) is to split petscvecmod.F90 into 2 source files - but I don't know if this will help with xlf..<br><br>My [partial] change is in branch balay/reorg-f90-for-xlf<br><br>Satish<br><br>On Wed, 3 Mar 2021, Satish Balay via petsc-dev wrote:<br><br><blockquote type="cite">On Wed, 3 Mar 2021, Satish Balay via petsc-dev wrote:<br><br><blockquote type="cite">Sure - once any change works locally [for gcc and xlf]<br><br>When I try - I get a bunch of errors.. [yet to digest them.]<br></blockquote><br><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Can you please give the following source code workaround a try?<br>Since there is already "use petscvecdefdummy" at the module scope, one workaround might be to remove the unnecessary "use petscvecdefdummy" in vecnotequal and vecequals <br>and all similar procedures.<br><br>For example, the test case has:<br> module petscvecdef<br> use petscvecdefdummy<br>...<br> function vecnotequal(A,B)<br> use petscvecdefdummy<br> logical vecnotequal<br> type(tVec), intent(in) :: A,B<br> vecnotequal = (A%v .ne. B%v)<br> end function<br></blockquote></blockquote></blockquote></blockquote></blockquote><br><br>Ok - try this suggestion:<br><br>diff --git a/src/vec/f90-mod/petscvecmod.F90 b/src/vec/f90-mod/petscvecmod.F90<br>index 0c447156b9..81968c7ca1 100644<br>--- a/src/vec/f90-mod/petscvecmod.F90<br>+++ b/src/vec/f90-mod/petscvecmod.F90<br>@@ -77,7 +77,6 @@<br> use petscvecdefdummy<br> interface operator(.ne.)<br> function vecnotequal(A,B)<br>- use petscvecdefdummy<br> logical vecnotequal<br> type(tVec), intent(in) :: A,B<br> end function<br><br><br><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote></blockquote> FC arch-linux-c-debug/obj/vec/f90-mod/petscvecmod.o<br>/home/balay/petsc/src/vec/f90-mod/petscvecmod.F90:81:22:<br><br> 81 | type(tVec), intent(in) :: A,B<br> | 1<br>Error: Derived type ‘tvec’ at (1) is being used before it is defined<br>/home/balay/petsc/include/../src/vec/f90-mod/ftn-auto-interfaces/petscis.h90:2:10:<br><br> 2 | use petscvecdef<br> | 1<br>Fatal Error: Cannot open module file ‘petscvecdef.mod’ for reading at (1): No such file or directory<br><<<<<<<br><br>Satish<br></blockquote></blockquote><br><br></blockquote></div></div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div></div></blockquote></div><br></div></div></div></div></div></div></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><div><br></div><div><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div></div></div></div>