<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Sorry for the noise, I'm now just realizing that it is in fact exactly the same bash-ism… (I prefer my “fix” though, but I guess the rest of Stefano’s comment still holds true).<div class=""><br class=""></div><div class="">Thanks,</div><div class="">Pierre<br class=""><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 20 Jan 2021, at 1:59 PM, Pierre Jolivet <<a href="mailto:pierre@joliv.et" class="">pierre@joliv.et</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On 20 Jan 2021, at 12:11 PM, Stefano Zampini <<a href="mailto:stefano.zampini@gmail.com" class="">stefano.zampini@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">This is an issue with the default shell used by the makefile. Below is my fix. We should probably have a CI machine that checks for these shell-related errors.</div></div></blockquote><div class=""><br class=""></div><div class="">I second this. Just spent too much time finding this other bash-ism in gmakefile.test… <a href="https://gitlab.com/petsc/petsc/-/commit/e4b11943e93779206a0e5f2091646de2e86b10e3#551c4017403b9179c385d5600f43348b6288a751" class="">https://gitlab.com/petsc/petsc/-/commit/e4b11943e93779206a0e5f2091646de2e86b10e3#551c4017403b9179c385d5600f43348b6288a751</a></div><div class=""><pre style="font-variant-ligatures: normal; orphans: 2; widows: 2; text-decoration-thickness: initial; overflow-wrap: break-word; white-space: pre-wrap;" class="">2021-01-20T11:21:22.5942304Z /usr/bin/sh: 1: test: false: unexpected operator
2021-01-20T11:21:22.5981176Z make: *** [gmakefile.test:270: check-test-errors] Error 1</pre></div><div class="">Thanks,</div><div class="">Pierre</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><div class="">diff --git a/gmakefile.test b/gmakefile.test<br class="">index c38e37f..ffd7bdb 100644<br class="">--- a/gmakefile.test<br class="">+++ b/gmakefile.test<br class="">@@ -379,10 +379,11 @@ starttime: pre-clean $(libpetscall)<br class=""> @$(eval STARTTIME := $(shell date +%s))<br class=""> <br class=""> report_tests: starttime $(TESTTARGETS)<br class="">+ifeq ($(showreport),true)<br class=""> @$(eval ENDTIME := $(shell date +%s))<br class="">- -@if test ${showreport} == "true"; then elapsed_time=$$(($(ENDTIME)- $(STARTTIME))) && \<br class="">- $(PYTHON) $(CONFIGDIR)/report_tests.py -m $(MAKE) -d $(TESTDIR)/counts -t 5 -e $${elapsed_time};\<br class="">- fi<br class="">+ elapsed_time=$$(($(ENDTIME)- $(STARTTIME))) && \<br class="">+ $(PYTHON) $(CONFIGDIR)/report_tests.py -m $(MAKE) -d $(TESTDIR)/counts -t 5 -e $${elapsed_time};<br class="">+endif<br class=""></div></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il giorno mar 19 gen 2021 alle ore 20:41 Scott Kruger <<a href="mailto:kruger@txcorp.com" class="">kruger@txcorp.com</a>> ha scritto:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF" class="">
<br class="">
<br class="">
<font size="+1" class="">I can't reproduce this with the latest master:<br class="">
<br class="">
hip 1261: git pull<br class="">
Already up to date.<br class="">
hip 1262: make -f gmakefile.test test search='notatest'<br class="">
Using MAKEFLAGS: -- search=notatest<br class="">
hip 1263:<br class="">
<br class="">
<br class="">
</font><br class="">
<div class="">On 1/19/21 8:19 AM, Stefano Zampini
wrote:<br class="">
</div>
<blockquote type="cite" class="">
<div dir="ltr" class="">Just rebased over latest master and got this
<div class=""><br class="">
</div>
<div class="">zampins@vulture:~/Devel/petsc$ make -f gmakefile.test test
search='notatest'<br class="">
Using MAKEFLAGS: -- search=notatest<br class="">
/bin/sh: 1: test: false: unexpected operator<br clear="all" class="">
<div class=""><br class="">
</div>
-- <br class="">
<div dir="ltr" class="">Stefano</div>
</div>
</div>
</blockquote>
<br class="">
<pre cols="72" class="">--
Tech-X Corporation <a href="mailto:kruger@txcorp.com" target="_blank" class="">kruger@txcorp.com</a>
5621 Arapahoe Ave, Suite A Phone: (720) 466-3196
Boulder, CO 80303 Fax: (303) 448-7756</pre>
</div>
</blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature">Stefano</div>
</div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></div></body></html>