<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">Am 29.09.2020 um 08:16 schrieb Barry Smith <<a href="mailto:bsmith@petsc.dev" class="">bsmith@petsc.dev</a>>:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Sep 29, 2020, at 12:43 AM, Patrick Sanan <<a href="mailto:patrick.sanan@gmail.com" class="">patrick.sanan@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">Am 29.09.2020 um 02:12 schrieb Barry Smith <<a href="mailto:bsmith@petsc.dev" class="">bsmith@petsc.dev</a>>:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class=""> This is a reminder for everyone submitting MR. <br class=""><br class=""> You are responsible to track the progress of the MR. Make sure you use the<br class=""><br class=""> label workflow:review when you think it is ready to be reviewed for merge, add additional appropriate labels also<br class=""> assign some appropriate reviewers <br class=""><br class=""> make sure it gets tested<br class=""><br class=""> when you resolve the reviewer concerns (called threads) make sure you mark them as resolved<br class=""><br class=""> Once the tests are clean and the MR has been approved<br class=""> - change the workflow label to workflow: ready for merge<br class=""> - assign Satish and no one else to the MR.<br class=""><br class=""> By following this workflow less MR will get "lost"<br class=""><br class=""> Thanks<br class=""><br class=""> Barry<br class=""><br class=""> With the new documentation approach in place we'll provide more detailed information on submitting MR and even videos :-) soon.<br class=""><br class=""><br class=""></div></div></blockquote></div>For now, the guidelines are defined are on the wiki, e.g. <a href="https://gitlab.com/petsc/petsc/-/wikis/home#before-filing-a-merge-request" class="">https://gitlab.com/petsc/petsc/-/wikis/home#before-filing-a-merge-request</a> <div class="">Some of the other wiki pages are stale (discussing what to do with "next", etc.,)</div><div class=""><br class=""></div><div class="">The idea was to migrate this info to Sphinx as well. This would be less quick to edit, but more centralized and full-featured.</div><div class=""><br class=""></div><div class="">On the topic of docs edits, is it okay to label a docs-only edit (which could break only docs) as "ready to merge", and assign Satish, from the start? </div><div class="">This would of course have to be used with extreme caution, but it's my hope that people would be able to notice and fix small typos and errors without losing the thread of what you're working on, and with low integration overhead (which is one thing the wiki does extremely well).</div></div></div></blockquote><br class=""></div><div class="">Yes, good idea. We could even have another person be the assigned person and do the merges so Satish doesn't get even more work. </div><div class=""><br class=""></div><div class="">I'd like to know an easy way to do the changes and MR from the web rather than needing to drop into the command line for making the branches to MR. Maybe that could be documented first? </div><div class=""><br class=""></div><div class=""> Barry</div><div class=""><br class=""></div><br class=""></div></div></blockquote>Added a section here (which can be directly edited): <a href="https://gitlab.com/petsc/petsc/-/wikis/Home#docs-only-changes" class="">https://gitlab.com/petsc/petsc/-/wikis/Home#docs-only-changes</a><div class="">(this should still be moved to the Sphinx docs, so we can easily link to it from the other developers docs)</div><div class=""><br class=""></div><div class="">And opened a MR here, using the instructions detailed in the MR: <a href="https://gitlab.com/petsc/petsc/-/merge_requests/3282" class="">https://gitlab.com/petsc/petsc/-/merge_requests/3282</a><br class=""></div><div class=""><br class=""></div></div><br class=""></div></body></html>