<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<a href="https://gitlab.com/petsc/petsc/-/merge_requests/3131" class="">https://gitlab.com/petsc/petsc/-/merge_requests/3131</a><br class="">
<div style=""><br class="">
<blockquote type="cite" class="">
<div class="">On 1 Sep 2020, at 11:33, Hapla Vaclav <<a href="mailto:vaclav.hapla@erdw.ethz.ch" class="">vaclav.hapla@erdw.ethz.ch</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">OK, so a new configure option which sets a certain make variable which then enables that parts of gmakefile.test, right?<br class="">
<br class="">
Something like —-with-add-macos-firewall-rules?<br class="">
<br class="">
So it would be still be possible to pass that variable to make without reconfigure. I guess that's fine, I even take it as an advantage, but probably doesn't need to be documented. Only the configure option should be properly explained in —-help output. Do
you agree?<br class="">
<br class="">
Vaclav<br class="">
<br class="">
<blockquote type="cite" class="">On 31 Aug 2020, at 19:46, Barry Smith <<a href="mailto:bsmith@petsc.dev" class="">bsmith@petsc.dev</a>> wrote:<br class="">
<br class="">
<br class="">
I would make your fix a configure option that is off by default. It is silly that Apple makes you use sudo to tell it that a compiled code SHOULD NOT accept outside connections but they have it all bundled together without enough thought for developers.<br class="">
<br class="">
Barry<br class="">
<br class="">
<br class="">
<blockquote type="cite" class="">On Aug 31, 2020, at 4:14 AM, Hapla Vaclav <<a href="mailto:vaclav.hapla@erdw.ethz.ch" class="">vaclav.hapla@erdw.ethz.ch</a>> wrote:<br class="">
<br class="">
<br class="">
<blockquote type="cite" class="">On 29 Aug 2020, at 02:03, Hapla Vaclav <<a href="mailto:vaclav.hapla@erdw.ethz.ch" class="">vaclav.hapla@erdw.ethz.ch</a>> wrote:<br class="">
<br class="">
<br class="">
<br class="">
<blockquote type="cite" class="">On 28 Aug 2020, at 22:47, Jed Brown <<a href="mailto:jed@jedbrown.org" class="">jed@jedbrown.org</a>> wrote:<br class="">
<br class="">
"Hapla Vaclav" <<a href="mailto:vaclav.hapla@erdw.ethz.ch" class="">vaclav.hapla@erdw.ethz.ch</a>> writes:<br class="">
<br class="">
<blockquote type="cite" class="">On MacOS, maybe you also have lots of firewall popups appearing/disappearing when running tests like<br class="">
Do you want the application "ex29" to accept incoming network connections?<br class="">
</blockquote>
<br class="">
Is there a way to express that the application does not need (should not accept) incoming connections?<br class="">
</blockquote>
<br class="">
Oh yes, hadn't thought about before, but it's surely better to _block_ the incoming connections - feels safer for a user at least.<br class="">
<br class="">
But the way is the same, requiring sudo:<br class="">
<br class="">
sudo /usr/libexec/ApplicationFirewall/socketfilterfw --add $PETSC_DIR/$PETSC_ARCH/tests/dm/impls/plex/tests/ex9<br class="">
sudo /usr/libexec/ApplicationFirewall/socketfilterfw --block $PETSC_DIR/$PETSC_ARCH/tests/dm/impls/plex/tests/ex9<br class="">
<br class="">
Funny enough, these commands don't fail without sudo but they have no effect.<br class="">
<br class="">
<blockquote type="cite" class=""><br class="">
Normalizing sudo during build/testing seems really bad.<br class="">
</blockquote>
<br class="">
I agree. It shouldn't be a normal part of the makefile. That's why I have been hesitant to create a MR. I think we could<br class="">
1. just add an FAQ entry - but the patch can become out-of-date pretty quickly, and instructions without a patch are gonna be tedious<br class="">
2. activate this part conditionally, requiring a user's action such as passing a very special variable to makefile<br class="">
3. put it into a separate makefile and add a commented out include into gmakefile.test, so that the user has to explicitly uncomment the inclusion - or something like that<br class="">
4. something else?<br class="">
</blockquote>
<br class="">
Jed, Barry, thoughts here?<br class="">
<br class="">
Thanks,<br class="">
Vaclav<br class="">
<br class="">
<blockquote type="cite" class=""><br class="">
Vaclav<br class="">
</blockquote>
<br class="">
</blockquote>
<br class="">
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</body>
</html>