<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 16 Oct 2019, at 8:01 PM, Zhang, Junchao <<a href="mailto:jczhang@mcs.anl.gov" class="">jczhang@mcs.anl.gov</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
<div class="">
<div dir="ltr" class="">
<div class="">The value of "owner" should fit in PetscMPIInt.</div></div></div></div></blockquote><div><br class=""></div><div>Are you implying that BuildSystem always promotes PetscInt to be able to store a PetscMPIInt (what if you configure with 32 bit indices and a 64 bit MPI implementation)?</div><div><br class=""></div><div>Thanks,</div><div>Pierre</div><div class=""><br class=""></div><blockquote type="cite" class=""><div class=""><div class=""><div dir="ltr" class=""><div class="">But if you change prototype of the two functions, you have to change all their uses.</div>
<div class="">In petsc, values representing MPI ranks are not always of type PetscMPIInt. Only those closely tied to MPI routines are in PetscMPIInt.</div>
<br clear="all" class="">
<div class="">
<div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr" class="">--Junchao Zhang</div>
</div>
</div>
<br class="">
</div>
<br class="">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Oct 16, 2019 at 5:19 AM Pierre Jolivet via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" class="">petsc-dev@mcs.anl.gov</a>> wrote:<br class="">
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Hello,<br class="">
These two functions use a parameter “owner” of type PetscInt*.<br class="">
Shouldn’t this be PetscMPIInt*?<br class="">
This implies changes left and right, so I want to check I’m not pushing an incorrect MR.<br class="">
<br class="">
Thanks,<br class="">
Pierre</blockquote>
</div>
</div>
</div></blockquote></div><br class=""></body></html>