<div dir="auto">Lisandro has a point. If someone includes petsc.h, he should be able to use petscsection stuff. So it has to go somewhere in the public headers</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il Gio 19 Set 2019, 12:26 Matthew Knepley <<a href="mailto:knepley@gmail.com">knepley@gmail.com</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I pushed the fix to the branch. Can we remerge it?<div><br></div><div>Also, I do not understand why tests did not catch this. Its obvious what happened. I added that header</div><div>to convert.c instead of convest.c.</div><div><br></div><div>   Matt</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 19, 2019 at 5:19 AM Stefano Zampini via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank" rel="noreferrer">petsc-dev@mcs.anl.gov</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">How come this was not caught by the tests? I think we have tests with -Werror </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il Gio 19 Set 2019, 12:15 Lisandro Dalcin via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank" rel="noreferrer">petsc-dev@mcs.anl.gov</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>The warnings below are from a C build. A C++ build fails right away.</div><div><br></div><div>We need to `#include <petscsection.h>` somewhere in the public headers, at least such that  `#include <petsc.h>` in user code works.</div><div><br></div><div>$ git grep petscsection include/<br>include/petsc/private/sectionimpl.h:#include <petscsection.h><br>include/petscis.h:#include <petscsectiontypes.h><br>include/petscsection.h:#include <petscsectiontypes.h><br></div><div><br></div><div><br></div>/home/devel/petsc/dev/src/snes/utils/convest.c: In function ‘PetscConvEstGetConvRate’:<br>/home/devel/petsc/dev/src/snes/utils/convest.c:293:14: warning: implicit declaration of function ‘PetscSectionGetField’; did you mean ‘PetscSectionVecView’? [-Wimplicit-function-declaration]<br>  293 |       ierr = PetscSectionGetField(s, f, &fs);CHKERRQ(ierr);<br>      |              ^~~~~~~~~~~~~~~~~~~~<br>      |              PetscSectionVecView<br>/home/devel/petsc/dev/src/snes/utils/convest.c:294:14: warning: implicit declaration of function ‘PetscSectionGetConstrainedStorageSize’ [-Wimplicit-function-declaration]<br>  294 |       ierr = PetscSectionGetConstrainedStorageSize(fs, &lsize);CHKERRQ(ierr);<br>      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div>Lisandro Dalcin<br>============<br>Research Scientist<br>Extreme Computing Research Center (ECRC)<br>King Abdullah University of Science and Technology (KAUST)<br><a href="http://ecrc.kaust.edu.sa/" rel="noreferrer noreferrer" target="_blank">http://ecrc.kaust.edu.sa/</a><br></div></div></div></div>
</blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><div><br></div><div><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank" rel="noreferrer">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div></div></div>
</blockquote></div>