<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 19 Sep 2019, at 11:25, Matthew Knepley via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" class="">petsc-dev@mcs.anl.gov</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">I pushed the fix to the branch. Can we remerge it?</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>I think best way would be to create another MR.</div>
<div><br class="">
</div>
<div>You should also add</div>
<div> #include <petscsection.h></div>
<div>to petscdmlabel.h.</div>
<div>This which will also satisfy Lisandro's point.</div>
<div><br class="">
</div>
<div>Vaclav</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" class="">
<div class=""><br class="">
</div>
<div class="">Also, I do not understand why tests did not catch this. Its obvious what happened. I added that header</div>
<div class="">to convert.c instead of convest.c.</div>
<div class=""><br class="">
</div>
<div class=""> Matt</div>
</div>
<br class="">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Sep 19, 2019 at 5:19 AM Stefano Zampini via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" class="">petsc-dev@mcs.anl.gov</a>> wrote:<br class="">
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="auto" class="">How come this was not caught by the tests? I think we have tests with -Werror </div>
<br class="">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Il Gio 19 Set 2019, 12:15 Lisandro Dalcin via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank" class="">petsc-dev@mcs.anl.gov</a>> ha scritto:<br class="">
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr" class="">
<div class="">The warnings below are from a C build. A C++ build fails right away.</div>
<div class=""><br class="">
</div>
<div class="">We need to `#include <petscsection.h>` somewhere in the public headers, at least such that `#include <petsc.h>` in user code works.</div>
<div class=""><br class="">
</div>
<div class="">$ git grep petscsection include/<br class="">
include/petsc/private/sectionimpl.h:#include <petscsection.h><br class="">
include/petscis.h:#include <petscsectiontypes.h><br class="">
include/petscsection.h:#include <petscsectiontypes.h><br class="">
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
/home/devel/petsc/dev/src/snes/utils/convest.c: In function ‘PetscConvEstGetConvRate’:<br class="">
/home/devel/petsc/dev/src/snes/utils/convest.c:293:14: warning: implicit declaration of function ‘PetscSectionGetField’; did you mean ‘PetscSectionVecView’? [-Wimplicit-function-declaration]<br class="">
293 | ierr = PetscSectionGetField(s, f, &fs);CHKERRQ(ierr);<br class="">
| ^~~~~~~~~~~~~~~~~~~~<br class="">
| PetscSectionVecView<br class="">
/home/devel/petsc/dev/src/snes/utils/convest.c:294:14: warning: implicit declaration of function ‘PetscSectionGetConstrainedStorageSize’ [-Wimplicit-function-declaration]<br class="">
294 | ierr = PetscSectionGetConstrainedStorageSize(fs, &lsize);CHKERRQ(ierr);<br class="">
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br class="">
<div class=""><br class="">
</div>
-- <br class="">
<div dir="ltr" class="">
<div dir="ltr" class="">
<div class="">Lisandro Dalcin<br class="">
============<br class="">
Research Scientist<br class="">
Extreme Computing Research Center (ECRC)<br class="">
King Abdullah University of Science and Technology (KAUST)<br class="">
<a href="http://ecrc.kaust.edu.sa/" rel="noreferrer" target="_blank" class="">http://ecrc.kaust.edu.sa/</a><br class="">
</div>
</div>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
<br clear="all" class="">
<div class=""><br class="">
</div>
-- <br class="">
<div dir="ltr" class="gmail_signature">
<div dir="ltr" class="">
<div class="">
<div dir="ltr" class="">
<div class="">
<div dir="ltr" class="">
<div class="">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br class="">
-- Norbert Wiener</div>
<div class=""><br class="">
</div>
<div class=""><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank" class="">https://www.cse.buffalo.edu/~knepley/</a><br class="">
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</body>
</html>