<div dir="ltr"><div dir="ltr">On Thu, Sep 19, 2019 at 5:22 AM Hapla  Vaclav via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov">petsc-dev@mcs.anl.gov</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">



<div style="word-wrap:break-word">
Looks like it was not tested at all...
<div><a href="https://gitlab.com/petsc/petsc/merge_requests/2065" target="_blank">https://gitlab.com/petsc/petsc/merge_requests/2065</a></div>
<div><br>
</div>
<div>Could there be a mechanism to prevent merging without testing?</div></div></blockquote><div><br></div><div>It was definitely tested, or we would not have caught the convert.c thing.</div><div><br></div><div>   Matt</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><div>
<blockquote type="cite">
<div>On 19 Sep 2019, at 11:18, Stefano Zampini via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank">petsc-dev@mcs.anl.gov</a>> wrote:</div>
<br>
<div>
<div dir="auto">How come this was not caught by the tests? I think we have tests with -Werror </div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Il Gio 19 Set 2019, 12:15 Lisandro Dalcin via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank">petsc-dev@mcs.anl.gov</a>> ha scritto:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>The warnings below are from a C build. A C++ build fails right away.</div>
<div><br>
</div>
<div>We need to `#include <petscsection.h>` somewhere in the public headers, at least such that  `#include <petsc.h>` in user code works.</div>
<div><br>
</div>
<div>$ git grep petscsection include/<br>
include/petsc/private/sectionimpl.h:#include <petscsection.h><br>
include/petscis.h:#include <petscsectiontypes.h><br>
include/petscsection.h:#include <petscsectiontypes.h><br>
</div>
<div><br>
</div>
<div><br>
</div>
/home/devel/petsc/dev/src/snes/utils/convest.c: In function ‘PetscConvEstGetConvRate’:<br>
/home/devel/petsc/dev/src/snes/utils/convest.c:293:14: warning: implicit declaration of function ‘PetscSectionGetField’; did you mean ‘PetscSectionVecView’? [-Wimplicit-function-declaration]<br>
  293 |       ierr = PetscSectionGetField(s, f, &fs);CHKERRQ(ierr);<br>
      |              ^~~~~~~~~~~~~~~~~~~~<br>
      |              PetscSectionVecView<br>
/home/devel/petsc/dev/src/snes/utils/convest.c:294:14: warning: implicit declaration of function ‘PetscSectionGetConstrainedStorageSize’ [-Wimplicit-function-declaration]<br>
  294 |       ierr = PetscSectionGetConstrainedStorageSize(fs, &lsize);CHKERRQ(ierr);<br>
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
<div><br>
</div>
-- <br>
<div dir="ltr">
<div dir="ltr">
<div>Lisandro Dalcin<br>
============<br>
Research Scientist<br>
Extreme Computing Research Center (ECRC)<br>
King Abdullah University of Science and Technology (KAUST)<br>
<a href="http://ecrc.kaust.edu.sa/" rel="noreferrer" target="_blank">http://ecrc.kaust.edu.sa/</a><br>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>

</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><div><br></div><div><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div></div></div></div>