<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Sep 19, 2019, at 1:23 PM, Matthew Knepley <<a href="mailto:knepley@gmail.com" class="">knepley@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div dir="ltr" class="">On Thu, Sep 19, 2019 at 6:21 AM Matthew Knepley <<a href="mailto:knepley@gmail.com" class="">knepley@gmail.com</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class=""><div dir="ltr" class="">On Thu, Sep 19, 2019 at 6:20 AM Stefano Zampini <<a href="mailto:stefano.zampini@gmail.com" target="_blank" class="">stefano.zampini@gmail.com</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="auto" class="">So why it is in the vec package?</div></blockquote><div class=""><br class=""></div><div class="">Its in IS, so if anything it should go in petscis.h. I will move it there.</div></div></div></blockquote><div class=""><br class=""></div><div class="">Now that we are doing this. I think petscsf.h belongs there too, not just the types.</div><div class=""><br class=""></div></div></div></div></blockquote><div><br class=""></div><div>Why? In order to use petscis.h You just need to forward declare PetscSF, which is what petscfstypes.h is supposed to do.</div><div>Our public header should just pass the test of preprocessing </div><div><br class=""></div><div>#include <petscxxx.h></div><div><br class=""></div><div>Without warning or errors. We should add this to the makefile rules </div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class="gmail_quote"><div class=""> Matt</div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class=""><div class="gmail_quote"><div class=""> Matt</div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il Gio 19 Set 2019, 13:17 Matthew Knepley <<a href="mailto:knepley@gmail.com" target="_blank" class="">knepley@gmail.com</a>> ha scritto:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class="">I made a new MR. DMLabel uses Section, whereas nothing else in Vec does.<div class=""><br class=""></div><div class=""> Matt</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 19, 2019 at 6:03 AM Stefano Zampini <<a href="mailto:stefano.zampini@gmail.com" rel="noreferrer" target="_blank" class="">stefano.zampini@gmail.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="auto" class="">Petscsection is part of the vec package. It belongs to petscvec.h</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il Gio 19 Set 2019, 12:50 Hapla Vaclav <<a href="mailto:vaclav.hapla@erdw.ethz.ch" rel="noreferrer" target="_blank" class="">vaclav.hapla@erdw.ethz.ch</a>> ha scritto:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On 19 Sep 2019, at 11:25, Matthew Knepley via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" rel="noreferrer noreferrer" target="_blank" class="">petsc-dev@mcs.anl.gov</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">I pushed the fix to the branch. Can we remerge it?</div></div></blockquote><div class=""><br class=""></div><div class="">I think best way would be to create another MR.</div><div class=""><br class=""></div><div class="">You should also add</div><div class=""> <span class="Apple-converted-space"> </span>#include <petscsection.h></div><div class="">to petscdmlabel.h.</div><div class="">This which will also satisfy Lisandro's point.</div><div class=""><br class=""></div><div class="">Vaclav</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">Also, I do not understand why tests did not catch this. Its obvious what happened. I added that header</div><div class="">to convert.c instead of convest.c.</div><div class=""><br class=""></div><div class=""> Matt</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Sep 19, 2019 at 5:19 AM Stefano Zampini via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" rel="noreferrer noreferrer" target="_blank" class="">petsc-dev@mcs.anl.gov</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="auto" class="">How come this was not caught by the tests? I think we have tests with -Werror </div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Il Gio 19 Set 2019, 12:15 Lisandro Dalcin via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" rel="noreferrer noreferrer" target="_blank" class="">petsc-dev@mcs.anl.gov</a>> ha scritto:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class=""><div class="">The warnings below are from a C build. A C++ build fails right away.</div><div class=""><br class=""></div><div class="">We need to `#include <petscsection.h>` somewhere in the public headers, at least such that `#include <petsc.h>` in user code works.</div><div class=""><br class=""></div><div class="">$ git grep petscsection include/<br class="">include/petsc/private/sectionimpl.h:#include <petscsection.h><br class="">include/petscis.h:#include <petscsectiontypes.h><br class="">include/petscsection.h:#include <petscsectiontypes.h><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div>/home/devel/petsc/dev/src/snes/utils/convest.c: In function ‘PetscConvEstGetConvRate’:<br class="">/home/devel/petsc/dev/src/snes/utils/convest.c:293:14: warning: implicit declaration of function ‘PetscSectionGetField’; did you mean ‘PetscSectionVecView’? [-Wimplicit-function-declaration]<br class=""> <span class="Apple-converted-space"> </span>293 | ierr = PetscSectionGetField(s, f, &fs);CHKERRQ(ierr);<br class=""> <span class="Apple-converted-space"> </span>| ^~~~~~~~~~~~~~~~~~~~<br class=""> <span class="Apple-converted-space"> </span>| PetscSectionVecView<br class="">/home/devel/petsc/dev/src/snes/utils/convest.c:294:14: warning: implicit declaration of function ‘PetscSectionGetConstrainedStorageSize’ [-Wimplicit-function-declaration]<br class=""> <span class="Apple-converted-space"> </span>294 | ierr = PetscSectionGetConstrainedStorageSize(fs, &lsize);CHKERRQ(ierr);<br class=""> <span class="Apple-converted-space"> </span>| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br class=""><div class=""><br class=""></div>--<span class="Apple-converted-space"> </span><br class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class="">Lisandro Dalcin<br class="">============<br class="">Research Scientist<br class="">Extreme Computing Research Center (ECRC)<br class="">King Abdullah University of Science and Technology (KAUST)<br class=""><a href="http://ecrc.kaust.edu.sa/" rel="noreferrer noreferrer noreferrer" target="_blank" class="">http://ecrc.kaust.edu.sa/</a><br class=""></div></div></div></div></blockquote></div></blockquote></div><br clear="all" class=""><div class=""><br class=""></div>--<span class="Apple-converted-space"> </span><br class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br class="">-- Norbert Wiener</div><div class=""><br class=""></div><div class=""><a href="http://www.cse.buffalo.edu/~knepley/" rel="noreferrer noreferrer" target="_blank" class="">https://www.cse.buffalo.edu/~knepley/</a><br class=""></div></div></div></div></div></div></div></div></blockquote></div><br class=""></div></blockquote></div></blockquote></div><br clear="all" class=""><div class=""><br class=""></div>--<span class="Apple-converted-space"> </span><br class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br class="">-- Norbert Wiener</div><div class=""><br class=""></div><div class=""><a href="http://www.cse.buffalo.edu/~knepley/" rel="noreferrer" target="_blank" class="">https://www.cse.buffalo.edu/~knepley/</a><br class=""></div></div></div></div></div></div></div></blockquote></div></blockquote></div><br clear="all" class=""><div class=""><br class=""></div>--<span class="Apple-converted-space"> </span><br class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br class="">-- Norbert Wiener</div><div class=""><br class=""></div><div class=""><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank" class="">https://www.cse.buffalo.edu/~knepley/</a><br class=""></div></div></div></div></div></div></div></div></blockquote></div><br clear="all" class=""><div class=""><br class=""></div>--<span class="Apple-converted-space"> </span><br class=""><div dir="ltr" class="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br class="">-- Norbert Wiener</div><div class=""><br class=""></div><div class=""><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank" class="">https://www.cse.buffalo.edu/~knepley/</a></div></div></div></div></div></div></div></div></div></blockquote></div><br class=""></body></html>