<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
OK, after grepping I can see that probably only Matt is using that _Internal suffix ;-)
<div class=""><br class="">
</div>
<div class="">I will rename it to PetscViewerHDF5Load_Private.</div>
<div class="">
<div class=""><br class="">
</div>
<div class="">Vaclav<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 20 Jun 2019, at 22:09, Václav Hapla via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" class="">petsc-dev@mcs.anl.gov</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Yes, I think that's the reason we moved it to private :-)<br class="">
<br class="">
Sometimes I see _Internal. I thought _Private is preferred for static functions visible only within a single object file?<br class="">
<br class="">
Vaclav<br class="">
<br class="">
<br class="">
<div class="gmail_quote">20. června 2019 21:50:29 SELČ, "Smith, Barry F." <<a href="mailto:bsmith@mcs.anl.gov" class="">bsmith@mcs.anl.gov</a>> napsal:
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br class="">It HAS A hid_t argument! Making it public means making HDF5 includes public, means all PETSc applications have the HDF5 includes open in them. Likely it should just get _Private <br class=""><br class=""> Barry<br class=""><br class=""><br class="">On Jun 20, 2019, at 9:01 AM, Hapla Vaclav via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" class="">petsc-dev@mcs.anl.gov</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br class="">On 20 Jun 2019, at 15:56, Vaclav Hapla <<a href="mailto:vaclav.hapla@erdw.ethz.ch" class="">vaclav.hapla@erdw.ethz.ch</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><br class="">/home/sandbox/petsc/petsc.next-3/src/mat/impls/dense/seq/densehdf5.c:62: undefined reference to `PetscViewerHDF5Load'<br class=""><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ccc; padding-left: 1ex;"><br class="">Does it mean I need to change visibility of PetscViewerHDF5Load in isimpl.h to PETSC_EXTERN?<br class="">Are you OK with that?<br class=""></blockquote><br class="">Yes, and when doing that, it needs a Developer level man page.<br class=""></blockquote><br class="">OK, thanks.<br class=""></blockquote><br class="">So as a rule of thumb, every PETSC_EXTERN function should be documented, although in private headers?<br class=""><br class="">Then src/vec/is/utils/hdf5io.c should have<br class="">#include <petsc/private/isimpl.h> /*I "petsc/private/isimpl.h" I*/<br class="">?<br class="">Looks a bit weird, doesn't it?<br class=""><br class="">I think there are countless cases petsc-wide which break this.<br class=""></blockquote><br class="">dev manual page 15 bullet 15:<br class="">"private functions may need to be marked PETSC_EXTERN"<br class="">There is an example of MatHeaderReplace. It hasn't a manpage.<br class=""><br class=""></blockquote><br class="">Well, I'm not against making it public (it originally was) and write a manpage, but then it should be also moved to the public header file.<br class=""><br class="">Sorry for sending a few previous emails only to Jed.<br class=""><br class="">Vaclav<br class=""><br class=""></blockquote><br class=""></pre>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</body>
</html>