<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div dir="ltr">PetscSF has many PETSC_HAVE_MPI_REDUCE_LOCAL. It is disturbing. But consider the time gap between MPI-2.0 (1998) and MPI-2.2 (2009), it is better to keep it.<br clear="all">
<div>
<div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr"><br>
</div>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, May 24, 2019 at 3:53 PM Jed Brown <<a href="mailto:jed@jedbrown.org">jed@jedbrown.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
"Zhang, Junchao" <<a href="mailto:jczhang@mcs.anl.gov" target="_blank">jczhang@mcs.anl.gov</a>> writes:<br>
<br>
> How about stuff in MPI-2.2 (approved in 2009), the last of MPI-2.x, e.g., PETSC_HAVE_MPI_REDUCE_LOCAL?<br>
<br>
Currently we only require MPI-2.0, but I would not object to increasing<br>
to MPI-2.1 or 2.2 if such systems are sufficiently rare (almost<br>
nonexistent) in the wild. I'm not sure how great the benefits are.<br>
<br>
> On Fri, May 24, 2019 at 2:51 PM Jed Brown via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank">petsc-dev@mcs.anl.gov</a><mailto:<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank">petsc-dev@mcs.anl.gov</a>>> wrote:<br>
> Lisandro Dalcin via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank">petsc-dev@mcs.anl.gov</a><mailto:<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank">petsc-dev@mcs.anl.gov</a>>> writes:<br>
><br>
>> These two are definitely wrong, we need PETSC_HAVE_MPI_XXX instead.<br>
><br>
> Thanks, we can delete both of these cpp guards.<br>
><br>
>> include/petscsf.h:#if defined(MPI_REPLACE)<br>
><br>
> MPI-2.0<br>
><br>
>> src/sys/objects/init.c:#if defined(PETSC_USE_64BIT_INDICES) ||<br>
>> !defined(MPI_2INT)<br>
><br>
> MPI-1.0<br>
</blockquote>
</div>
</body>
</html>