<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 8 May 2019, at 14:08, Patrick Sanan <<a href="mailto:patrick.sanan@gmail.com" class="">patrick.sanan@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">
<div dir="ltr" class=""><br class="">
</div>
<br class="">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Am Mi., 8. Mai 2019 um 14:03 Uhr schrieb Matthew Knepley via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" class="">petsc-dev@mcs.anl.gov</a>>:<br class="">
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div dir="ltr" class="">
<div dir="ltr" class="">On Wed, May 8, 2019 at 7:41 AM Hapla Vaclav via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" target="_blank" class="">petsc-dev@mcs.anl.gov</a>> wrote:<br class="">
</div>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
Hello<br class="">
<br class="">
I just encountered their manpages and it's a mess. I think in case of file I/O, a user should be deliberate about filename and other settings. Sometimes less is more and I think this is the case. Why anybody should use PETSC_VIEWER_BINARY_(comm) and then set
the filename with environment variable? Better to use PetscObjectViewFromOptions for instance (PETSC_OPTIONS can be used if one wants to use env var).<br class="">
<br class="">
(And BTW in case of HDF5, the option -viewer_hdf5_filename is not processed anywhere.)<br class="">
<br class="">
Any objections about removing these?<br class="">
</blockquote>
<div class=""><br class="">
</div>
<div class="">I am fine with it. The new system is better.</div>
<div class=""><br class="">
</div>
<div class="">Since these are user interface, we should deprecate them somehow. Will the normal deprecation work?</div>
</div>
</div>
</blockquote>
<div class="">These are functions (albeit weirdly-named ones which don't return error codes), so one would assume that the usual function deprecation procedure would work, and then things like PETSC_VIEWER_BINARY_WORLD would also show up as deprecated.</div>
</div>
</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>... Which I think is correct. I meant also PETSC_VIEWER_BINARY_{SELF,WORLD}.</div>
<div><br class="">
</div>
<div>I would even suggest to keep just PETSC_VIEWER_STDOUT* stuff (used most often and with least additional settings needed), or nothing at all.</div>
<div><br class="">
</div>
<div>Users should be encouraged to use stuff controllable from the options database.</div>
<div>I think changing the PetscViewerType by rewriting the hard-wired PETSC_VIEWER_* call sounds legacy.</div>
<div>If one insists on setting up everything using API, still it is more flexible to just use PetscViewerSetType and/or PetscViewerSetFromOptions.</div>
<div><br class="">
</div>
<div>Thanks,</div>
<div>Vaclav</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" class="">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div dir="ltr" class="">
<div class="gmail_quote">
<div class=""><br class="">
</div>
<div class=""> Thanks,</div>
<div class=""><br class="">
</div>
<div class=""> Matt</div>
<div class=""> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
Vaclav</blockquote>
</div>
<br clear="all" class="">
<div class=""><br class="">
</div>
-- <br class="">
<div dir="ltr" class="gmail-m_7505211777710551270gmail_signature">
<div dir="ltr" class="">
<div class="">
<div dir="ltr" class="">
<div class="">
<div dir="ltr" class="">
<div class="">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br class="">
-- Norbert Wiener</div>
<div class=""><br class="">
</div>
<div class=""><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank" class="">https://www.cse.buffalo.edu/~knepley/</a><br class="">
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</body>
</html>