<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 8, 2019, at 2:37 PM, Matthew Knepley <<a href="mailto:knepley@gmail.com" class="">knepley@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class="">On Fri, Feb 8, 2019 at 6:30 AM Stefano Zampini via petsc-dev <<a href="mailto:petsc-dev@mcs.anl.gov" class="">petsc-dev@mcs.anl.gov</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word" class="">I don’t understand the need of these checks (tacky and incomplete…, as per the comment) <div class=""><br class=""></div><div class=""><a href="https://bitbucket.org/petsc/petsc/src/75aeaa18afd73be7f3020f94b788241b9e0ba3d7/src/dm/impls/shell/dmshell.c#lines-197" target="_blank" class="">https://bitbucket.org/petsc/petsc/src/75aeaa18afd73be7f3020f94b788241b9e0ba3d7/src/dm/impls/shell/dmshell.c#lines-197</a><div class=""><br class=""></div><div class="">Why are these checks needed? I’m inclined to remove these lines, but I would like some comments before doing it.</div></div></div></blockquote></div><br clear="all" class=""><div class="">This even looks wrong to me. Why would we accept a type different from the actual matrix type?</div><div class=""><br class=""></div></div></div></blockquote><div><br class=""></div><div>The only reason I could think of is</div><div><br class=""></div><div><div>DMSetMatType(shell,type1);</div></div><div><div>DMCreateMatrix(shell,&A);</div></div><div><div><div>DMSetMatType(shell,type2);</div><div class=""><div><div>DMCreateMatrix(shell,&B); // B is type1, not type2</div><div><br class=""></div></div></div></div></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""> Matt</div><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class="">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br class="">-- Norbert Wiener</div><div class=""><br class=""></div><div class=""><a href="http://www.cse.buffalo.edu/~knepley/" target="_blank" class="">https://www.cse.buffalo.edu/~knepley/</a><br class=""></div></div></div></div></div></div></div></div>
</div></blockquote></div><br class=""></body></html>