<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Wed, Jun 13, 2018 at 9:57 AM Smith, Barry F. <<a href="mailto:bsmith@mcs.anl.gov">bsmith@mcs.anl.gov</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
> On Jun 12, 2018, at 9:36 PM, Satish Balay <<a href="mailto:balay@mcs.anl.gov" target="_blank">balay@mcs.anl.gov</a>> wrote:<br>
> <br>
> Sure - that will work.<br>
> <br>
> But ultimately - if superlu and superlu_dist are separate packages<br>
> (and meant to be used from the same applicaton)- they should not have<br>
> any include files - that are common.<br>
> <br>
> If they have common files - then there should be some version check<br>
> that prevent the wrong version of the common file from used.<br>
> <br>
> Or perhaps some other better organizaton of files between the packages<br>
> is possible.<br>
> <br>
> Alternative is - PETSc configure should eror out if one tries to use<br>
> both packages at the same time.<br>
<br>
We don't like this at all. Applications should be able to switch between packages at runtime not require reconfiguring and rebuild etc.<br></blockquote><div><br></div><div>Not meaning to butt-in, but I wanted to reenforce this point from the user perspective because we do this *all the time* (superlu in serial, then superlu_dist in parallel) and would be very frustrating if it went away.</div><div><br></div><div>Thanks,</div><div><br></div><div>Paul</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Barry<br>
<br>
> <br>
> Satish<br>
> <br>
> On Tue, 12 Jun 2018, Xiaoye S. Li wrote:<br>
> <br>
>> Satish,<br>
>> <br>
>> I forgot to update sequential superlu. Right now I am busy with a paper<br>
>> deadline on Friday. If I couldn't get to it before then, will certainly do<br>
>> it on Saturday.<br>
>> <br>
>> Is it sufficient to just update the master branch, without doing a new<br>
>> tarball release?<br>
>> <br>
>> Sherry<br>
>> <br>
>> <br>
>> On Tue, Jun 12, 2018 at 11:00 AM, Satish Balay <<a href="mailto:balay@mcs.anl.gov" target="_blank">balay@mcs.anl.gov</a>> wrote:<br>
>> <br>
>>> For now - removed from next [until I figureout how to handle it]<br>
>>> <br>
>>> One motivation for this change is xsdk@devel build [wrt ATPESC tutorials].<br>
>>> <br>
>>> Satish<br>
>>> <br>
>>> On Tue, 12 Jun 2018, Smith, Barry F. wrote:<br>
>>> <br>
>>>> <br>
>>>> Complain to Sherry and have her fix it before moving the new release<br>
>>> into PETSc<br>
>>>> <br>
>>>> Barry<br>
>>>> <br>
>>>> <br>
>>>>> On Jun 12, 2018, at 10:59 AM, Satish Balay <<a href="mailto:balay@mcs.anl.gov" target="_blank">balay@mcs.anl.gov</a>> wrote:<br>
>>>>> <br>
>>>>> <br>
>>>>> $ diff superlu/SRC/superlu_enum_consts.h<br>
>>> superlu_dist/SRC/superlu_enum_consts.h<br>
>>>>> 16a17<br>
>>>>>> * January 28, 2018<br>
>>>>> 28c29<br>
>>>>> < typedef enum {NOROWPERM, LargeDiag, MY_PERMR}<br>
>>> rowperm_t;<br>
>>>>> ---<br>
>>>>>> typedef enum {NOROWPERM, LargeDiag_MC64, LargeDiag_AWPM, MY_PERMR}<br>
>>> rowperm_t;<br>
>>>>> 34c35,36<br>
>>>>> < typedef enum {LUSUP, UCOL, LSUB, USUB, LLVL, ULVL}<br>
>>> MemType;<br>
>>>>> ---<br>
>>>>>> //typedef enum {LUSUP, UCOL, LSUB, USUB, LLVL, ULVL, NO_MEMTYPE}<br>
>>> MemType;<br>
>>>>>> typedef enum {USUB, LSUB, UCOL, LUSUP, LLVL, ULVL, NO_MEMTYPE}<br>
>>> MemType;<br>
>>>>> 69a72,74<br>
>>>>>> COMM_DIAG, /* Bcast diagonal block to process column */<br>
>>>>>> COMM_RIGHT, /* communicate L panel */<br>
>>>>>> COMM_DOWN, /* communicate U panel */<br>
>>>>> <br>
>>>>> So superlu and superlu_dist share the same 'superlu_enum_consts.h'<br>
>>>>> file - but with differences that are now incompatible with each other.<br>
>>>>> <br>
>>>>> I'm not sure how to resolve this..<br>
>>>>> <br>
>>>>> Satish<br>
>>>>> <br>
>>>>> On Tue, 12 Jun 2018, PETSc checkBuilds wrote:<br>
>>>>> <br>
>>>>>> <br>
>>>>>> <br>
>>>>>> Dear PETSc developer,<br>
>>>>>> <br>
>>>>>> This email contains listings of contributions attributed to you by<br>
>>>>>> `git blame` that caused compiler errors or warnings in PETSc automated<br>
>>>>>> testing. Follow the links to see the full log files. Please attempt<br>
>>> to fix<br>
>>>>>> the issues promptly or let us know at <a href="mailto:petsc-dev@mcs.anl.gov" target="_blank">petsc-dev@mcs.anl.gov</a> if you<br>
>>> are unable<br>
>>>>>> to resolve the issues.<br>
>>>>>> <br>
>>>>>> Thanks,<br>
>>>>>> The PETSc development team<br>
>>>>>> <br>
>>>>>> ----<br>
>>>>>> <br>
>>>>>> warnings attributed to commit <a href="https://bitbucket.org/petsc/" rel="noreferrer" target="_blank">https://bitbucket.org/petsc/</a><br>
>>> petsc/commits/8e05559<br>
>>>>>> superlu_dist: update to version v5.4.0<br>
>>>>>> <br>
>>>>>> src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:571<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-freebsd-cxx-pkgs-opt_wii.log]<br>
>>>>>> /usr/home/balay/petsc.next-2/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:571:8:<br>
>>> error: 'LargeDiag_MC64' was not declared in this scope<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-linux-pkgs-cxx-mlib_el6.log]<br>
>>>>>> /home/sandbox/petsc/petsc.next-3/src/mat/impls/aij/mpi/<br>
>>> superlu_dist/superlu_dist.c:571:8: error: 'LargeDiag_MC64' was not<br>
>>> declared in this scope<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-osx-10.6-cxx-cmplx-pkgs-dbg_ipro.log]<br>
>>>>>> /Users/petsc/petsc.next-3/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:571:8:<br>
>>> error: use of undeclared identifier 'LargeDiag_MC64'<br>
>>>>>> <br>
>>>>>> src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:574<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-freebsd-cxx-pkgs-opt_wii.log]<br>
>>>>>> /usr/home/balay/petsc.next-2/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:574:8:<br>
>>> error: 'LargeDiag_AWPM' was not declared in this scope<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-linux-pkgs-cxx-mlib_el6.log]<br>
>>>>>> /home/sandbox/petsc/petsc.next-3/src/mat/impls/aij/mpi/<br>
>>> superlu_dist/superlu_dist.c:574:8: error: 'LargeDiag_AWPM' was not<br>
>>> declared in this scope<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-osx-10.6-cxx-cmplx-pkgs-dbg_ipro.log]<br>
>>>>>> /Users/petsc/petsc.next-3/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:574:8:<br>
>>> error: use of undeclared identifier 'LargeDiag_AWPM'<br>
>>>>>> <br>
>>>>>> src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:720<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-linux-pkgs-cxx-mlib_el6.log]<br>
>>>>>> /home/sandbox/petsc/petsc.next-3/src/mat/impls/aij/mpi/<br>
>>> superlu_dist/superlu_dist.c:720:25: error: 'LargeDiag_MC64' was not<br>
>>> declared in this scope<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-osx-10.6-cxx-cmplx-pkgs-dbg_ipro.log]<br>
>>>>>> /Users/petsc/petsc.next-3/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:720:25:<br>
>>> error: use of undeclared identifier 'LargeDiag_MC64'<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-freebsd-cxx-pkgs-opt_wii.log]<br>
>>>>>> /usr/home/balay/petsc.next-2/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:720:25:<br>
>>> error: 'LargeDiag_MC64' was not declared in this scope<br>
>>>>>> <br>
>>>>>> src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:723<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-osx-10.6-cxx-cmplx-pkgs-dbg_ipro.log]<br>
>>>>>> /Users/petsc/petsc.next-3/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:723:25:<br>
>>> error: use of undeclared identifier 'LargeDiag_AWPM'<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-freebsd-cxx-pkgs-opt_wii.log]<br>
>>>>>> /usr/home/balay/petsc.next-2/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:723:25:<br>
>>> error: 'LargeDiag_AWPM' was not declared in this scope<br>
>>>>>> [<a href="http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/" rel="noreferrer" target="_blank">http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/</a><br>
>>> 2018/06/12/build_next_arch-linux-pkgs-cxx-mlib_el6.log]<br>
>>>>>> /home/sandbox/petsc/petsc.next-3/src/mat/impls/aij/mpi/<br>
>>> superlu_dist/superlu_dist.c:723:25: error: 'LargeDiag_AWPM' was not<br>
>>> declared in this scope<br>
>>>>>> <br>
>>>>>> ----<br>
>>>>>> To opt-out from receiving these messages - send a request to<br>
>>> <a href="mailto:petsc-dev@mcs.anl.gov" target="_blank">petsc-dev@mcs.anl.gov</a>.<br>
>>>>>> <br>
>>>>> <br>
>>>> <br>
>>> <br>
>>> <br>
>> <br>
> <br>
<br>
</blockquote></div></div>