<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 31 January 2018 at 20:37, Satish Balay <span dir="ltr"><<a href="mailto:balay@mcs.anl.gov" target="_blank">balay@mcs.anl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">sorry - fixed now.<br>
<br></blockquote><div><br></div><div>Thanks.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
[I thought I tested it before pushing - but apparently not! bad workflow]<br>
<span class="gmail-HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div>I know you've been discussing this recently, but we've found that lightweight branch testing (we've been using <a href="https://circleci.com/">https://circleci.com/</a>) has taken our success rate for full next testing from around 60% to over 90%. It would pick up errors like this one within a minute of pushing to a branch.</div><div><br></div><div>Garth</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-HOEnZb"><font color="#888888">
Satish<br>
</font></span><div class="gmail-HOEnZb"><div class="gmail-h5"><br>
On Wed, 31 Jan 2018, Garth N. Wells wrote:<br>
<br>
> The green bits here:<br>
><br>
> <a href="https://bitbucket.org/petsc/petsc/commits/b9693abc333a4cb54c29596de4de4a2160c61cc0" rel="noreferrer" target="_blank">https://bitbucket.org/petsc/<wbr>petsc/commits/<wbr>b9693abc333a4cb54c29596de4de4a<wbr>2160c61cc0</a><br>
><br>
> ain't proper Python. Breaks config. Not sure how this gets past your<br>
> testing . . . .<br>
><br>
> Garth<br>
><br>
<br>
</div></div></blockquote></div><div class="gmail_signature"><br></div>
</div></div>