<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">8. 11. 2017 v 14:52, Jed Brown <<a href="mailto:jed@jedbrown.org" class="">jed@jedbrown.org</a>>:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Matthew Knepley <</span><a href="mailto:knepley@gmail.com" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">knepley@gmail.com</a><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> writes:</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">On Wed, Nov 8, 2017 at 4:52 AM, Vaclav Hapla <<a href="mailto:vaclav.hapla@erdw.ethz.ch" class="">vaclav.hapla@erdw.ethz.ch</a>><br class="">wrote:<br class=""><br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">8. 11. 2017 v 9:06, Lisandro Dalcin <<a href="mailto:dalcinl@gmail.com" class="">dalcinl@gmail.com</a>>:<br class=""><br class="">On 8 November 2017 at 05:51, Smith, Barry F. <<a href="mailto:bsmith@mcs.anl.gov" class="">bsmith@mcs.anl.gov</a>> wrote:<br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">On Nov 7, 2017, at 1:33 AM, Lisandro Dalcin <<a href="mailto:dalcinl@gmail.com" class="">dalcinl@gmail.com</a>> wrote:<br class=""><br class="">The only concern I have about PetscPartitioner is that the API depends<br class="">on DM (PetscPartitionerPartition_<TYPE> routines). Maybe<br class="">PetscPartitioner should eventually move to became more agnostic, and<br class="">that way it can be used to partition matrices and meshes.<br class=""></blockquote><br class=""> This is certainly a serious flaw if PetscPartitioner is intended as<br class=""></blockquote></blockquote>THE API to use for partitioning. If it is not intended as THE API for<br class="">partitioning then that is also a problem, because why have multiple APIs<br class="">for what is essentially one set of abstractions.<br class=""><blockquote type="cite" class=""><blockquote type="cite" class=""><br class=""></blockquote><br class="">Note however that things looks easy to refactor. I'll try to team up<br class="">with Matt to improve things.<br class=""></blockquote><br class="">Wait, now we are at the beginning again. I actually wanted to do some<br class="">refactoring of PetscPartitioner, starting with few cosmetic changes to make<br class="">it better settable from options. But Barry kept me back of any edits since<br class="">he think it's anti-systematic to keep two independent classes doing<br class="">essentially the same. And I agree with that to be honest. It's strange to<br class="">have two ParMetis, two Scotch and two whatever interfaces. The only thing I<br class="">don't like on MatPartitioning is its name as it's not just for Mat<br class="">Partitioning :-)<br class=""><br class="">There are from my point of view multiple issues with PetscPartitioner.<br class="">Let's look e.g. at PetscPartitionerPartition. It takes as arguments both<br class="">PetscPartitioner and DM. This DM must be in fact DMPlex which is not<br class="">checked so it will probably crash somewhere deep in the stack once the<br class="">first DMPlex specific line is reached. Then there are two output arguments<br class="">PetscSection partSection and IS *partition. The first must be created<br class="">beforehand while the second is created inside. And I guess they must keep<br class="">the same basic information just in two different forms.<br class=""><br class=""></blockquote><br class="">This is wrong.<br class=""></blockquote></div></blockquote><div><br class=""></div><div>Matt, do you mean what I wrote above is not true (then I'm going to prove that it's true), or the opposite that the PetscPartitionerPartition design is actually not good :-)</div><div><br class=""></div><div>Vaclav</div><div><br class=""></div><blockquote type="cite" class=""><div class=""><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Dude, this isn't how we interaction here. If there is a technical</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">reason why what Vaclav, Lisandro, and Barry want to do cannot work, you</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">should explain that. Just casting doubt without working toward a</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">solution is not okay.</span></div></blockquote></div><br class=""></body></html>