<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Oct 24, 2017 at 4:22 PM, Adrian Croucher <span dir="ltr"><<a href="mailto:a.croucher@auckland.ac.nz" target="_blank">a.croucher@auckland.ac.nz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    <p>hi,<br>
    </p>
    <br>
    <div class="m_9094851077545998858moz-cite-prefix">On 11/10/17 22:18, Matthew Knepley
      wrote:<br>
    </div>
    <blockquote type="cite">
      
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">On Tue, Oct 10, 2017 at 9:07 PM,
            Adrian Croucher <span dir="ltr"><<a href="mailto:a.croucher@auckland.ac.nz" target="_blank">a.croucher@auckland.ac.nz</a>></span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div text="#000000" bgcolor="#FFFFFF">
                <p>hi<br>
                </p>
                <span> <br>
                  <div class="m_9094851077545998858m_8227166731894965972moz-cite-prefix">On
                    03/08/17 13:10, Matthew Knepley wrote:<br>
                  </div>
                  <blockquote type="cite">
                    <div dir="ltr">
                      <div class="gmail_extra">
                        <div class="gmail_quote">On Wed, Aug 2, 2017 at
                          8:06 PM, Adrian Croucher <span dir="ltr"><<a href="mailto:a.croucher@auckland.ac.nz" target="_blank">a.croucher@auckland.ac.nz</a>></span>
                          wrote:<br>
                          <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I haven't tried
                            this myself, but two of my colleagues are
                            reporting problems accessing DMLabel from
                            Fortran, when using the latest 'next'
                            branch.<br>
                            <br>
                            Previously, #include
                            <petsc/finclude/petsc.h> and then 'use
                            petsc' would give access to DMLabel.<br>
                            <br>
                            But now it appears that doesn't work- you
                            need to include petscdmlabel.h as well.<br>
                            <br>
                            Is that a bug or a feature?</blockquote>
                          <div><br>
                          </div>
                          <div>Its a bug. We refactored DMLabel to make
                            all functionality available from Fortran,
                            including using it as a type, but</div>
                          <div>I did not put the new header inside
                            petsc.h. I can do that.</div>
                          <div><br>
                          </div>
                          <div>   Matt</div>
                          <div> </div>
                        </div>
                      </div>
                    </div>
                  </blockquote>
                  <br>
                </span> It appears this never got done, so I have had a
                look and (I think) figured out how to fix it myself.<br>
                <br>
                I've just submitted a pull request with the fix in a
                branch called acroucher/fix-fortran-dmlabel.</div>
            </blockquote>
            <div><br>
            </div>
            <div>Sorry about that. We will get this in this week.</div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    Was there a problem with that? It doesn't appear to have been merged
    in yet.</div></blockquote><div><br></div><div>This is me being stupid. I needed to rebase it onto maint and I forgot about it. I merged it to next just now.</div><div>If everything is fine tomorrow, I will merge to maint and master.</div><div><br></div><div>  Thanks,</div><div><br></div><div>    Matt</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><span class="HOEnZb"><font color="#888888"><br>
    - Adrian<br>
    <pre class="m_9094851077545998858moz-signature" cols="72">-- 
Dr Adrian Croucher
Senior Research Fellow
Department of Engineering Science
University of Auckland, New Zealand
email: <a class="m_9094851077545998858moz-txt-link-abbreviated" href="mailto:a.croucher@auckland.ac.nz" target="_blank">a.croucher@auckland.ac.nz</a>
tel: <a href="tel:+64%209-923%204611" value="+6499234611" target="_blank">+64 (0)9 923 4611</a>
</pre>
  </font></span></div>

</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div><div><br></div><div><a href="http://www.caam.rice.edu/~mk51/" target="_blank">https://www.cse.buffalo.edu/~knepley/</a><br></div></div></div></div></div>
</div></div>