<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">pushed a fix<div><a href="https://bitbucket.org/petsc/petsc/commits/ae287a2e7a141494f7c41f9dd537addb63b556e3">https://bitbucket.org/petsc/petsc/commits/ae287a2e7a141494f7c41f9dd537addb63b556e3</a></div><div><br></div><div>However, it appears that the functions below for CUSP, CUSPARSE and VIENNACL are mere copies of the interface.</div><div>What about defining the type of the Vec in the interface and get rid of these?<br><div><br></div><div><div style="margin: 0px; font-size: 14px; font-family: Menlo;">src/mat/impls/aij/mpi/mpicusp/mpiaijcusp.cu: A->ops->getvecs = MatCreateVecs_MPIAIJCUSP;</div><div style="margin: 0px; font-size: 14px; font-family: Menlo;">src/mat/impls/aij/mpi/mpicusparse/mpiaijcusparse.cu: A->ops->getvecs = MatCreateVecs_MPIAIJCUSPARSE;</div><div style="margin: 0px; font-size: 14px; font-family: Menlo;">src/mat/impls/aij/mpi/mpiviennacl/mpiaijviennacl.cxx: A->ops->getvecs = MatCreateVecs_MPIAIJViennaCL;</div><div style="margin: 0px; font-size: 14px; font-family: Menlo;">src/mat/impls/aij/seq/seqcusp/aijcusp.cu: B->ops->getvecs = MatCreateVecs_SeqAIJCUSP;</div><div style="margin: 0px; font-size: 14px; font-family: Menlo;">src/mat/impls/aij/seq/seqcusparse/aijcusparse.cu: B->ops->getvecs = MatCreateVecs_SeqAIJCUSPARSE;</div><div style="margin: 0px; font-size: 14px; font-family: Menlo;">src/mat/impls/aij/seq/seqviennacl/aijviennacl.cxx: B->ops->getvecs = MatCreateVecs_SeqAIJViennaCL;</div></div><div><br></div><div>Stefano</div><div><br></div><div><br></div><div><div><div>On Jun 25, 2015, at 4:34 PM, Barry Smith <<a href="mailto:bsmith@mcs.anl.gov">bsmith@mcs.anl.gov</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br> I think you are right, go ahead and make a pull request or send a patch<br><br> Barry<br><br><blockquote type="cite">On Jun 25, 2015, at 9:43 AM, Stefano Zampini <<a href="mailto:stefano.zampini@gmail.com">stefano.zampini@gmail.com</a>> wrote:<br><br>Why the current interface in MatCreateVecs requires that a matrix has been already either allocated or setup ?<br>Shouldn’t be enough to check if the layout has been already setup?<br><br>Stefano<br><br></blockquote><br></blockquote></div><br></div></div></body></html>