<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Feb 19, 2015 at 2:39 PM, Jed Brown <span dir="ltr"><<a href="mailto:jed@jedbrown.org" target="_blank">jed@jedbrown.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">Matthew Knepley <<a href="mailto:knepley@gmail.com">knepley@gmail.com</a>> writes:<br>
<br>
> On Thu, Feb 19, 2015 at 1:42 AM, Lisandro Dalcin <<a href="mailto:dalcinl@gmail.com">dalcinl@gmail.com</a>> wrote:<br>
><br>
>> Please take look to the last line of the following output:<br>
>><br>
>> $ grep include $PETSC_DIR/include/petsc-private/dmpleximpl.h<br>
>> #include <petscmat.h>       /*I      "petscmat.h"          I*/<br>
>> #include <petscdmplex.h> /*I      "petscdmplex.h"    I*/<br>
>> #include <petscbt.h><br>
>> #include <petscsf.h><br>
>> #include <petsc-private/dmimpl.h><br>
>> #include <../src/sys/utils/hash.h><br>
>><br>
><br>
> It does not look like anything else uses hash.h. Can we just move it to<br>
> include/petschash.h?<br>
<br>
</span>Why does it need to be included by a header?<br>
</blockquote></div><br>I thought something else was using this, but it looks like I am the only one. We</div><div class="gmail_extra">should put it in a header and clear out the cruft no one uses anymore:</div><div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_extra">knepley/feature-harmonic-advection *$:/PETSc3/petsc/petsc-dev$ find ./src -type f | xargs grep hash.h</div><div class="gmail_extra">find ./src -type f | xargs grep hash.h</div><div class="gmail_extra">./src/dm/impls/plex/plexinterpolate.c:#include <../src/sys/utils/hash.h></div><div class="gmail_extra">./src/dm/impls/plex/plexinterpolate.c~:#include <../src/sys/utils/hash.h></div><div class="gmail_extra">./src/dm/impls/plex/plextree.c:#include <../src/sys/utils/hash.h></div><div class="gmail_extra">./src/sys/examples/tests/ex26.c:#include <../src/sys/utils/hash.h></div><div class="gmail_extra">./src/sys/utils/hash.h:#include <khash.h></div><div class="gmail_extra"> 1knepley/feature-harmonic-advection *$:/PETSc3/petsc/petsc-dev$ find ./include -type f | xargs grep hash.h</div><div class="gmail_extra">find ./include -type f | xargs grep hash.h</div><div class="gmail_extra">./include/petsc-private/dmpleximpl.h:#include <../src/sys/utils/hash.h></div><div><br></div><div>  Matt</div><div><br></div>-- <br><div class="gmail_signature">What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead.<br>-- Norbert Wiener</div>
</div></div>